Remove USB support for tl-mr3020

Submitted by Fabian Blaese on Nov. 29, 2018, 6:21 p.m.

Details

Message ID 20181129182114.68219-1-fabian@blaese.de
State Accepted
Headers show

Commit Message

Fabian Blaese Nov. 29, 2018, 6:21 p.m.
USB support is removed because of very limited flash.
This allows building for tl-mr3020 again.

USB support has no known use case for this firmware.
Most usb devices would require additional drivers anyway.

Signed-off-by: Fabian Bläse <fabian@blaese.de>
---
 bsp/ar71xx/.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/bsp/ar71xx/.config b/bsp/ar71xx/.config
index 43c9537..0e74914 100644
--- a/bsp/ar71xx/.config
+++ b/bsp/ar71xx/.config
@@ -15,7 +15,7 @@  CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_cpe210-220-v1=""
 CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_cpe510-520-v1=y
 CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_cpe510-520-v1=""
 CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_tl-mr3020-v1=y
-CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_tl-mr3020-v1="-uboot-envtools"
+CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_tl-mr3020-v1="-uboot-envtools -kmod-usb-core -kmod-usb2 -kmod-usb-ledtrig-usbport"
 CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_tl-wa850re-v1=y
 CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_tl-wa850re-v1=""
 CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_tl-wa860re-v1=y

Comments

Adrian Schmutzler Nov. 29, 2018, 6:47 p.m.
Hallo,

Reviewed-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

Wäre noch spannend zu überlegen, ob der Wegfall von dem ledtrig nen Fehler irgendwo auslöst oder ob das abgefangen wird.

Grüße

Adrian

> -----Original Message-----
> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of
> Fabian Bläse
> Sent: Donnerstag, 29. November 2018 19:21
> To: franken-dev@freifunk.net
> Subject: [PATCH] Remove USB support for tl-mr3020
> 
> USB support is removed because of very limited flash.
> This allows building for tl-mr3020 again.
> 
> USB support has no known use case for this firmware.
> Most usb devices would require additional drivers anyway.
> 
> Signed-off-by: Fabian Bläse <fabian@blaese.de>
> ---
>  bsp/ar71xx/.config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bsp/ar71xx/.config b/bsp/ar71xx/.config
> index 43c9537..0e74914 100644
> --- a/bsp/ar71xx/.config
> +++ b/bsp/ar71xx/.config
> @@ -15,7 +15,7 @@
> CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_cpe210-220-v1=""
>  CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_cpe510-520-v1=y
>  CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_cpe510-520-v1=""
>  CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_tl-mr3020-v1=y
> -CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_tl-mr3020-v1="-
> uboot-envtools"
> +CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_tl-mr3020-v1="-
> uboot-envtools -kmod-usb-core -kmod-usb2 -kmod-usb-ledtrig-usbport"
>  CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_tl-wa850re-v1=y
>  CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_tl-wa850re-v1=""
>  CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_tl-wa860re-v1=y
> --
> 2.19.1
Adrian Schmutzler Dec. 2, 2018, 12:57 p.m.
Wie besprochen: Applied.

 

From: Adrian Schmutzler [mailto:mail@adrianschmutzler.de] 
Sent: Donnerstag, 29. November 2018 19:48
To: 'Fabian Bläse' <fabian@blaese.de>; franken-dev@freifunk.net
Subject: RE: [PATCH] Remove USB support for tl-mr3020

 

Hallo, 

Reviewed-by: Adrian Schmutzler <freifunk@adrianschmutzler.de <mailto:freifunk@adrianschmutzler.de> > 

Wäre noch spannend zu überlegen, ob der Wegfall von dem ledtrig nen Fehler irgendwo auslöst oder ob das abgefangen wird.

Grüße 

Adrian 

> -----Original Message----- 
> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of 
> Fabian Bläse 
> Sent: Donnerstag, 29. November 2018 19:21 
> To: franken-dev@freifunk.net <mailto:franken-dev@freifunk.net>  
> Subject: [PATCH] Remove USB support for tl-mr3020 
> 
> USB support is removed because of very limited flash. 
> This allows building for tl-mr3020 again. 
> 
> USB support has no known use case for this firmware. 
> Most usb devices would require additional drivers anyway. 
> 
> Signed-off-by: Fabian Bläse <fabian@blaese.de <mailto:fabian@blaese.de> > 
> --- 
>  bsp/ar71xx/.config | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
> 
> diff --git a/bsp/ar71xx/.config b/bsp/ar71xx/.config 
> index 43c9537..0e74914 100644 
> --- a/bsp/ar71xx/.config 
> +++ b/bsp/ar71xx/.config 
> @@ -15,7 +15,7 @@ 
> CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_cpe210-220-v1="" 
>  CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_cpe510-520-v1=y 
>  CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_cpe510-520-v1="" 
>  CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_tl-mr3020-v1=y 
> -CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_tl-mr3020-v1="- 
> uboot-envtools" 
> +CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_tl-mr3020-v1="- 
> uboot-envtools -kmod-usb-core -kmod-usb2 -kmod-usb-ledtrig-usbport" 
>  CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_tl-wa850re-v1=y 
>  CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_tl-wa850re-v1="" 
>  CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_tl-wa860re-v1=y 
> -- 
> 2.19.1