[v3] fff-batman-adv: Enable bridge loop avoidance (BLA)

Submitted by Adrian Schmutzler on Nov. 28, 2018, 1:27 p.m.

Details

Message ID 20181128132720.14001-1-freifunk@adrianschmutzler.de
State Accepted
Headers show

Commit Message

Adrian Schmutzler Nov. 28, 2018, 1:27 p.m. 
Based on the documentation, BLA will only help if two nodes
are connected via WiFi AND via Ethernet cable on CLIENT ports!
For a "correct" setup, e.g. WiFi and BATMAN port connection,
BLA won't have an effect.

Since the former case is possible and there are no known
drawbacks, we enable BLA.

This removes the line to disable BLA, so it will be enabled as
B.A.T.M.A.N. enables it by default.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
Reviewed-by: Christian Dresel <fff@chrisi01.de>

---

Changes in v2:
- Don't set to 1, but remove line

Changes in v3:
- Rephrased commit message
---
 src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv | 1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox 

diff --git a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv
index f312c491..93c822c5 100644
--- a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv
+++ b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv
@@ -5,7 +5,6 @@  uci batch <<EOF
   set batman-adv.bat0=mesh
   set batman-adv.bat0.gw_mode='client'
   set batman-adv.bat0.gw_sel_class='1'
-  set batman-adv.bat0.bridge_loop_avoidance='0'
   set batman-adv.bat0.network_coding='0'
   set batman-adv.bat0.aggregated_ogms='1'
   set batman-adv.bat0.ap_isolation='0'

Comments

Adrian Schmutzler Dec. 5, 2018, 6:32 p.m. 
Applied.

> -----Original Message-----
> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of
> Adrian Schmutzler
> Sent: Mittwoch, 28. November 2018 14:27
> To: franken-dev@freifunk.net
> Subject: [PATCH v3] fff-batman-adv: Enable bridge loop avoidance (BLA)
> 
> Based on the documentation, BLA will only help if two nodes
> are connected via WiFi AND via Ethernet cable on CLIENT ports!
> For a "correct" setup, e.g. WiFi and BATMAN port connection,
> BLA won't have an effect.
> 
> Since the former case is possible and there are no known
> drawbacks, we enable BLA.
> 
> This removes the line to disable BLA, so it will be enabled as
> B.A.T.M.A.N. enables it by default.
> 
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> Reviewed-by: Christian Dresel <fff@chrisi01.de>
> 
> ---
> 
> Changes in v2:
> - Don't set to 1, but remove line
> 
> Changes in v3:
> - Rephrased commit message
> ---
>  src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-
> batman-adv b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-
> batman-adv
> index f312c491..93c822c5 100644
> --- a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv
> +++ b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-
> adv
> @@ -5,7 +5,6 @@ uci batch <<EOF
>    set batman-adv.bat0=mesh
>    set batman-adv.bat0.gw_mode='client'
>    set batman-adv.bat0.gw_sel_class='1'
> -  set batman-adv.bat0.bridge_loop_avoidance='0'
>    set batman-adv.bat0.network_coding='0'
>    set batman-adv.bat0.aggregated_ogms='1'
>    set batman-adv.bat0.ap_isolation='0'
> --
> 2.11.0