| Message ID | 20181128124843.13284-1-freifunk@adrianschmutzler.de |
|---|---|
| State | Superseded |
| Headers | show |
diff --git a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv index f312c491..93c822c5 100644 --- a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv +++ b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv @@ -5,7 +5,6 @@ uci batch <<EOF set batman-adv.bat0=mesh set batman-adv.bat0.gw_mode='client' set batman-adv.bat0.gw_sel_class='1' - set batman-adv.bat0.bridge_loop_avoidance='0' set batman-adv.bat0.network_coding='0' set batman-adv.bat0.aggregated_ogms='1' set batman-adv.bat0.ap_isolation='0'
Hi Nachdem Fabian mir bestätigt hat das ich es richtig verstanden habe: Reviewed-by: Christian Dresel <fff@chrisi01.de> Von meiner Seite gerne noch vor beta mit einkippen Mfg Christian Am 28. November 2018 13:48:43 MEZ schrieb Adrian Schmutzler <freifunk@adrianschmutzler.de>: >Although many people say it does not apply to our setup, it is >enabled by default and there are no known drawbacks. > >This removes the line to disable BLA, so it will be enabled as >B.A.T.M.A.N. enables it by default. > >Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > >--- > >Changes in v2: >- Don't set to 1, but remove line >--- >src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv >| 1 - > 1 file changed, 1 deletion(-) > >diff --git >a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv >b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv >index f312c491..93c822c5 100644 >--- >a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv >+++ >b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv >@@ -5,7 +5,6 @@ uci batch <<EOF > set batman-adv.bat0=mesh > set batman-adv.bat0.gw_mode='client' > set batman-adv.bat0.gw_sel_class='1' >- set batman-adv.bat0.bridge_loop_avoidance='0' > set batman-adv.bat0.network_coding='0' > set batman-adv.bat0.aggregated_ogms='1' > set batman-adv.bat0.ap_isolation='0' >-- >2.11.0
Würde folgendes noch als Commit Message ergänzen (siehe Christians Mail): Based on the documentation, BLA will only help if two nodes are connected via WiFi AND via Ethernet cable on CLIENT ports! For a "correct" setup, e.g. WiFi and BATMAN port connection, BLA won't have an effect. > -----Original Message----- > From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of > Adrian Schmutzler > Sent: Mittwoch, 28. November 2018 13:49 > To: franken-dev@freifunk.net > Subject: [PATCH v2] fff-batman-adv: Enable bridge loop avoidance > > Although many people say it does not apply to our setup, it is > enabled by default and there are no known drawbacks. > > This removes the line to disable BLA, so it will be enabled as > B.A.T.M.A.N. enables it by default. > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > > --- > > Changes in v2: > - Don't set to 1, but remove line > --- > src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff- > batman-adv b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff- > batman-adv > index f312c491..93c822c5 100644 > --- a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv > +++ b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman- > adv > @@ -5,7 +5,6 @@ uci batch <<EOF > set batman-adv.bat0=mesh > set batman-adv.bat0.gw_mode='client' > set batman-adv.bat0.gw_sel_class='1' > - set batman-adv.bat0.bridge_loop_avoidance='0' > set batman-adv.bat0.network_coding='0' > set batman-adv.bat0.aggregated_ogms='1' > set batman-adv.bat0.ap_isolation='0' > -- > 2.11.0
Wir haben gerade beschlossen, dass wir noch bis nach dem aktuellen Release warten wollen und danach applien. Ich werde daher jetzt noch eine v3 mit der veränderten Commit-Message schicken, damit ich das dann nicht nochmal zusammenpfriemeln muss. Grüße Adrian From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of Adrian Schmutzler Sent: Mittwoch, 28. November 2018 13:55 To: franken-dev@freifunk.net Subject: RE: [PATCH v2] fff-batman-adv: Enable bridge loop avoidance Würde folgendes noch als Commit Message ergänzen (siehe Christians Mail): Based on the documentation, BLA will only help if two nodes are connected via WiFi AND via Ethernet cable on CLIENT ports! For a "correct" setup, e.g. WiFi and BATMAN port connection, BLA won't have an effect. > -----Original Message----- > From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of > Adrian Schmutzler > Sent: Mittwoch, 28. November 2018 13:49 > To: franken-dev@freifunk.net <mailto:franken-dev@freifunk.net> > Subject: [PATCH v2] fff-batman-adv: Enable bridge loop avoidance > > Although many people say it does not apply to our setup, it is > enabled by default and there are no known drawbacks. > > This removes the line to disable BLA, so it will be enabled as > B.A.T.M.A.N. enables it by default. > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de <mailto:freifunk@adrianschmutzler.de> > > > --- > > Changes in v2: > - Don't set to 1, but remove line > --- > src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff- > batman-adv b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff- > batman-adv > index f312c491..93c822c5 100644 > --- a/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv > +++ b/src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman- > adv > @@ -5,7 +5,6 @@ uci batch <<EOF > set batman-adv.bat0=mesh > set batman-adv.bat0.gw_mode='client' > set batman-adv.bat0.gw_sel_class='1' > - set batman-adv.bat0.bridge_loop_avoidance='0' > set batman-adv.bat0.network_coding='0' > set batman-adv.bat0.aggregated_ogms='1' > set batman-adv.bat0.ap_isolation='0' > -- > 2.11.0
Although many people say it does not apply to our setup, it is enabled by default and there are no known drawbacks. This removes the line to disable BLA, so it will be enabled as B.A.T.M.A.N. enables it by default. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> --- Changes in v2: - Don't set to 1, but remove line --- src/packages/fff/fff-batman-adv/files/etc/uci-defaults/93-fff-batman-adv | 1 - 1 file changed, 1 deletion(-)