| Message ID | 20181030113215.30320-1-freifunk@adrianschmutzler.de |
|---|---|
| State | Accepted |
| Headers | show |
diff --git a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods index c2f56bba..997e4b76 100644 --- a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods +++ b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods @@ -1 +1 @@ -3-59/5 * * * * [ -f /tmp/started ] && /usr/sbin/configurehood +3-59/5 * * * * /bin/sleep $(/usr/bin/random 1 15); [ -f /tmp/started ] && /usr/sbin/configurehood
Hi Adrian, so ist es doch schön simpel. Und es berührt das configurehood Skript nicht, das damit ja eigentlich nix zu tun hat. Es geht ja um den KeyEx. Reviewed-by: Robert Langhammer <rlanghammer@web.de> Am 30.10.2018 um 12:32 schrieb Adrian Schmutzler: > Instead of having 1000 routers accessing the KeyXchange in the > same second, this will dilute the request within a period of > 10 seconds. > > Same is done for queries from gateways. > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > > --- > > Changes in v2: > - Moved sleep to micron.d > - Use full path for sleep > - Increase upper limit to 15 seconds > --- > src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > index c2f56bba..997e4b76 100644 > --- a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > +++ b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > @@ -1 +1 @@ > -3-59/5 * * * * [ -f /tmp/started ] && /usr/sbin/configurehood > +3-59/5 * * * * /bin/sleep $(/usr/bin/random 1 15); [ -f /tmp/started ] && /usr/sbin/configurehood
Hi Ich häng mich dran: Reviewed-by: Christian Dresel <fff@chrisi01.de> Mini Kleinigkeit noch online, vllt. beim applien einfach anpassen? Am 30. Oktober 2018 12:56:44 MEZ schrieb Robert Langhammer <rlanghammer@web.de>: >Hi Adrian, > >so ist es doch schön simpel. Und es berührt das configurehood Skript >nicht, das damit ja eigentlich nix zu tun hat. Es geht ja um den KeyEx. > >Reviewed-by: Robert Langhammer <rlanghammer@web.de> > > >Am 30.10.2018 um 12:32 schrieb Adrian Schmutzler: >> Instead of having 1000 routers accessing the KeyXchange in the >> same second, this will dilute the request within a period of >> 10 seconds. 15 oder ;) Mfg Christian >> >> Same is done for queries from gateways. >> >> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> >> >> --- >> >> Changes in v2: >> - Moved sleep to micron.d >> - Use full path for sleep >> - Increase upper limit to 15 seconds >> --- >> src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods >b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods >> index c2f56bba..997e4b76 100644 >> --- a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods >> +++ b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods >> @@ -1 +1 @@ >> -3-59/5 * * * * [ -f /tmp/started ] && /usr/sbin/configurehood >> +3-59/5 * * * * /bin/sleep $(/usr/bin/random 1 15); [ -f /tmp/started >] && /usr/sbin/configurehood
Ist mir auch schon aufgefallen mit der commit description, mach ich beim Applien. > -----Original Message----- > From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of > Christian Dresel > Sent: Dienstag, 30. Oktober 2018 16:57 > To: Robert Langhammer <rlanghammer@web.de>; franken-dev@freifunk.net > Subject: Re: [PATCH v2] configurehood: Introduce random delays to dilute > requests > > Hi > > Ich häng mich dran: > > Reviewed-by: Christian Dresel <fff@chrisi01.de> > > Mini Kleinigkeit noch online, vllt. beim applien einfach anpassen? > > Am 30. Oktober 2018 12:56:44 MEZ schrieb Robert Langhammer > <rlanghammer@web.de>: > >Hi Adrian, > > > >so ist es doch schön simpel. Und es berührt das configurehood Skript > >nicht, das damit ja eigentlich nix zu tun hat. Es geht ja um den KeyEx. > > > >Reviewed-by: Robert Langhammer <rlanghammer@web.de> > > > > > >Am 30.10.2018 um 12:32 schrieb Adrian Schmutzler: > >> Instead of having 1000 routers accessing the KeyXchange in the > >> same second, this will dilute the request within a period of > >> 10 seconds. > > 15 oder ;) > > Mfg > > Christian > > >> > >> Same is done for queries from gateways. > >> > >> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > >> > >> --- > >> > >> Changes in v2: > >> - Moved sleep to micron.d > >> - Use full path for sleep > >> - Increase upper limit to 15 seconds > >> --- > >> src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git > >a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > >b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > >> index c2f56bba..997e4b76 100644 > >> --- a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > >> +++ b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > >> @@ -1 +1 @@ > >> -3-59/5 * * * * [ -f /tmp/started ] && /usr/sbin/configurehood > >> +3-59/5 * * * * /bin/sleep $(/usr/bin/random 1 15); [ -f /tmp/started > >] && /usr/sbin/configurehood > > -- > Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
Ui, noch bisschen mehr Randfälle für das Ding, was eh schon viel zu viele Randfälle hat. Bin gespannt, ob das irgendwo explodiert.. Wir sollten zusehen dass wir sicherstellen, dass das Skript nicht mehrfach laufen kann. Einen passenden Patch, der nochmals diskutiert werden müsste, gibts dazu ja schon. Gruß Fabian On 30.10.18 12:32, Adrian Schmutzler wrote: > Instead of having 1000 routers accessing the KeyXchange in the > same second, this will dilute the request within a period of > 10 seconds. > > Same is done for queries from gateways. > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > > --- > > Changes in v2: > - Moved sleep to micron.d > - Use full path for sleep > - Increase upper limit to 15 seconds > --- > src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > index c2f56bba..997e4b76 100644 > --- a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > +++ b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > @@ -1 +1 @@ > -3-59/5 * * * * [ -f /tmp/started ] && /usr/sbin/configurehood > +3-59/5 * * * * /bin/sleep $(/usr/bin/random 1 15); [ -f /tmp/started ] && /usr/sbin/configurehood >
Mit Randfälle meinst du, was bei unterschiedlichen randoms passiert? From: Fabian Bläse [mailto:fabian@blaese.de] Sent: Dienstag, 30. Oktober 2018 17:22 To: Adrian Schmutzler <freifunk@adrianschmutzler.de>; franken-dev@freifunk.net Subject: Re: [PATCH v2] configurehood: Introduce random delays to dilute requests Ui, noch bisschen mehr Randfälle für das Ding, was eh schon viel zu viele Randfälle hat. Bin gespannt, ob das irgendwo explodiert.. Wir sollten zusehen dass wir sicherstellen, dass das Skript nicht mehrfach laufen kann. Einen passenden Patch, der nochmals diskutiert werden müsste, gibts dazu ja schon. Gruß Fabian On 30.10.18 12:32, Adrian Schmutzler wrote: > Instead of having 1000 routers accessing the KeyXchange in the > same second, this will dilute the request within a period of > 10 seconds. > > Same is done for queries from gateways. > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de <mailto:freifunk@adrianschmutzler.de> > > > --- > > Changes in v2: > - Moved sleep to micron.d > - Use full path for sleep > - Increase upper limit to 15 seconds > --- > src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > index c2f56bba..997e4b76 100644 > --- a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > +++ b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > @@ -1 +1 @@ > -3-59/5 * * * * [ -f /tmp/started ] && /usr/sbin/configurehood > +3-59/5 * * * * /bin/sleep $(/usr/bin/random 1 15); [ -f /tmp/started ] && /usr/sbin/configurehood >
Applied. > -----Original Message----- > From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of > Adrian Schmutzler > Sent: Dienstag, 30. Oktober 2018 12:32 > To: franken-dev@freifunk.net > Subject: [PATCH v2] configurehood: Introduce random delays to dilute requests > > Instead of having 1000 routers accessing the KeyXchange in the > same second, this will dilute the request within a period of > 10 seconds. > > Same is done for queries from gateways. > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > > --- > > Changes in v2: > - Moved sleep to micron.d > - Use full path for sleep > - Increase upper limit to 15 seconds > --- > src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > index c2f56bba..997e4b76 100644 > --- a/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > +++ b/src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods > @@ -1 +1 @@ > -3-59/5 * * * * [ -f /tmp/started ] && /usr/sbin/configurehood > +3-59/5 * * * * /bin/sleep $(/usr/bin/random 1 15); [ -f /tmp/started ] && > /usr/sbin/configurehood > -- > 2.11.0
Instead of having 1000 routers accessing the KeyXchange in the same second, this will dilute the request within a period of 10 seconds. Same is done for queries from gateways. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> --- Changes in v2: - Moved sleep to micron.d - Use full path for sleep - Increase upper limit to 15 seconds --- src/packages/fff/fff-hoods/files/usr/lib/micron.d/fff-hoods | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)