| Message ID | 1461486291-8770-1-git-send-email-tim@tn-x.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
diff --git a/target/linux/ar71xx/image/Makefile b/target/linux/ar71xx/image/Makefile index 1a399ab..9b41943 100644 --- a/target/linux/ar71xx/image/Makefile +++ b/target/linux/ar71xx/image/Makefile @@ -548,21 +548,21 @@ define Device/tl-wr743nd-v2 endef TARGET_DEVICES += tl-wr740n-v4 tl-wr740n-v5 tl-wr741nd-v1 tl-wr741nd-v2 tl-wr741nd-v4 tl-wr741nd-v5 tl-wr743nd-v2 -define Device/tl-wr841-v8 +define Device/tl-wr841n-v8 $(Device/tplink-4mlzma) BOARDNAME := TL-WR841N-v8 DEVICE_PROFILE := TLWR841 TPLINK_HWID := 0x08410008 endef -define Device/tl-wr841-v9 +define Device/tl-wr841n-v9 $(Device/tplink-4mlzma) BOARDNAME := TL-WR841N-v9 DEVICE_PROFILE := TLWR841 TPLINK_HWID := 0x08410009 endef -define Device/tl-wr841-v10 +define Device/tl-wr841n-v10 $(Device/tplink-4mlzma) BOARDNAME := TL-WR841N-v9 DEVICE_PROFILE := TLWR841 @@ -589,7 +589,7 @@ define Device/tl-wr847n-v8 DEVICE_PROFILE := TLWR841 TPLINK_HWID := 0x08470008 endef -TARGET_DEVICES += tl-wr841-v8 tl-wr841-v9 tl-wr841-v10 tl-wr842n-v2 tl-wr843nd-v1 tl-wr847n-v8 +TARGET_DEVICES += tl-wr841n-v8 tl-wr841n-v9 tl-wr841n-v10 tl-wr842n-v2 tl-wr843nd-v1 tl-wr847n-v8 define Device/tl-wr941nd-v5 $(Device/tplink-4mlzma) @@ -2008,13 +2008,13 @@ $(eval $(call SingleProfile,Seama,64k,QIHOO360,qihoo-c301,QIHOO-C301,ttyS0,11520 $(eval $(call SingleProfile,Senao,squashfs-only,EAP300V2,eap300v2,EAP300V2,ttyS0,115200,$$(eap300v2_mtdlayout))) -$(eval $(call SingleProfile,TPLINKOLD,squashfs-only,TLWR841NV15,tl-wr841-v1.5,TL-WR841N-v1.5,ttyS0,115200,0x08410002,2,4M)) +$(eval $(call SingleProfile,TPLINKOLD,squashfs-only,TLWR841NV15,tl-wr841nd-v1.5,TL-WR841N-v1.5,ttyS0,115200,0x08410002,2,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,RNXN360RT,rnx-n360rt,TL-WR941ND,ttyS0,115200,0x09410002,0x00420001,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLMR3220V1,tl-mr3220-v1,TL-MR3220,ttyS0,115200,0x32200001,1,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLMR3420V1,tl-mr3420-v1,TL-MR3420,ttyS0,115200,0x34200001,1,4M)) -$(eval $(call SingleProfile,TPLINK,64kraw,TLWA701NV1,tl-wa701nd-v1,TL-WA901ND,ttyS0,115200,0x07010001,1,4M)) -$(eval $(call SingleProfile,TPLINK,64kraw,TLWA730REV1,tl-wa730re-v1,TL-WA901ND,ttyS0,115200,0x07300001,1,4M)) +$(eval $(call SingleProfile,TPLINK,64kraw,TLWA701NV1,tl-wa701n-v1,TL-WA901ND,ttyS0,115200,0x07010001,1,4M)) +$(eval $(call SingleProfile,TPLINK,64kraw,TLWA730REV1,tl-wa730rev1,TL-WA901ND,ttyS0,115200,0x07300001,1,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLWA7510NV1,tl-wa7510n,TL-WA7510N,ttyS0,115200,0x75100001,1,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLWA801NV1,tl-wa801nd-v1,TL-WA901ND,ttyS0,115200,0x08010001,1,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLWA830RV1,tl-wa830re-v1,TL-WA901ND,ttyS0,115200,0x08300010,1,4M)) @@ -2023,9 +2023,9 @@ $(eval $(call SingleProfile,TPLINK,64kraw,TLWA901NV2,tl-wa901nd-v2,TL-WA901ND-v2 $(eval $(call SingleProfile,TPLINK,64kraw,TLWR740NV1,tl-wr740n-v1,TL-WR741ND,ttyS0,115200,0x07400001,1,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLWR740NV3,tl-wr740n-v3,TL-WR741ND,ttyS0,115200,0x07400003,1,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLWR743NV1,tl-wr743nd-v1,TL-WR741ND,ttyS0,115200,0x07430001,1,4M)) -$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV3,tl-wr841-v3,TL-WR941ND,ttyS0,115200,0x08410003,3,4M)) -$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV5,tl-wr841-v5,TL-WR741ND,ttyS0,115200,0x08410005,1,4M)) -$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV7,tl-wr841-v7,TL-WR841N-v7,ttyS0,115200,0x08410007,1,4M)) +$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV3,tl-wr841nd-v3,TL-WR941ND,ttyS0,115200,0x08410003,3,4M)) +$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV5,tl-wr841nd-v5,TL-WR741ND,ttyS0,115200,0x08410005,1,4M)) +$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV7,tl-wr841nd-v7,TL-WR841N-v7,ttyS0,115200,0x08410007,1,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLWR842V1,tl-wr842n-v1,TL-MR3420,ttyS0,115200,0x08420001,1,8M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLWR941NV2,tl-wr941nd-v2,TL-WR941ND,ttyS0,115200,0x09410002,2,4M)) $(eval $(call SingleProfile,TPLINK,64kraw,TLWR941NV3,tl-wr941nd-v3,TL-WR941ND,ttyS0,115200,0x09410002,2,4M))
On 24/04/2016 10:24, Tim Niemeyer wrote: > This reverts commit 0fd48fd7dab066db8a46e51775579c9ef507ca25. > > We are facing some problem on rolling out the current 15.05-branch to > our devices because the image name changed. > > The changed image name breaks compatibility for derived projects and > that's something which should only happen if there is a really good > reason (e.g. security fix). > how does it beak compatibility ? > Signed-off-by: Tim Niemeyer <tim@tn-x.org> > --- > > target/linux/ar71xx/image/Makefile | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/target/linux/ar71xx/image/Makefile b/target/linux/ar71xx/image/Makefile > index 1a399ab..9b41943 100644 > --- a/target/linux/ar71xx/image/Makefile > +++ b/target/linux/ar71xx/image/Makefile > @@ -548,21 +548,21 @@ define Device/tl-wr743nd-v2 > endef > TARGET_DEVICES += tl-wr740n-v4 tl-wr740n-v5 tl-wr741nd-v1 tl-wr741nd-v2 tl-wr741nd-v4 tl-wr741nd-v5 tl-wr743nd-v2 > > -define Device/tl-wr841-v8 > +define Device/tl-wr841n-v8 > $(Device/tplink-4mlzma) > BOARDNAME := TL-WR841N-v8 > DEVICE_PROFILE := TLWR841 > TPLINK_HWID := 0x08410008 > endef > > -define Device/tl-wr841-v9 > +define Device/tl-wr841n-v9 > $(Device/tplink-4mlzma) > BOARDNAME := TL-WR841N-v9 > DEVICE_PROFILE := TLWR841 > TPLINK_HWID := 0x08410009 > endef > > -define Device/tl-wr841-v10 > +define Device/tl-wr841n-v10 > $(Device/tplink-4mlzma) > BOARDNAME := TL-WR841N-v9 > DEVICE_PROFILE := TLWR841 > @@ -589,7 +589,7 @@ define Device/tl-wr847n-v8 > DEVICE_PROFILE := TLWR841 > TPLINK_HWID := 0x08470008 > endef > -TARGET_DEVICES += tl-wr841-v8 tl-wr841-v9 tl-wr841-v10 tl-wr842n-v2 tl-wr843nd-v1 tl-wr847n-v8 > +TARGET_DEVICES += tl-wr841n-v8 tl-wr841n-v9 tl-wr841n-v10 tl-wr842n-v2 tl-wr843nd-v1 tl-wr847n-v8 > > define Device/tl-wr941nd-v5 > $(Device/tplink-4mlzma) > @@ -2008,13 +2008,13 @@ $(eval $(call SingleProfile,Seama,64k,QIHOO360,qihoo-c301,QIHOO-C301,ttyS0,11520 > > $(eval $(call SingleProfile,Senao,squashfs-only,EAP300V2,eap300v2,EAP300V2,ttyS0,115200,$$(eap300v2_mtdlayout))) > > -$(eval $(call SingleProfile,TPLINKOLD,squashfs-only,TLWR841NV15,tl-wr841-v1.5,TL-WR841N-v1.5,ttyS0,115200,0x08410002,2,4M)) > +$(eval $(call SingleProfile,TPLINKOLD,squashfs-only,TLWR841NV15,tl-wr841nd-v1.5,TL-WR841N-v1.5,ttyS0,115200,0x08410002,2,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,RNXN360RT,rnx-n360rt,TL-WR941ND,ttyS0,115200,0x09410002,0x00420001,4M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLMR3220V1,tl-mr3220-v1,TL-MR3220,ttyS0,115200,0x32200001,1,4M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLMR3420V1,tl-mr3420-v1,TL-MR3420,ttyS0,115200,0x34200001,1,4M)) > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWA701NV1,tl-wa701nd-v1,TL-WA901ND,ttyS0,115200,0x07010001,1,4M)) > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWA730REV1,tl-wa730re-v1,TL-WA901ND,ttyS0,115200,0x07300001,1,4M)) > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWA701NV1,tl-wa701n-v1,TL-WA901ND,ttyS0,115200,0x07010001,1,4M)) > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWA730REV1,tl-wa730rev1,TL-WA901ND,ttyS0,115200,0x07300001,1,4M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLWA7510NV1,tl-wa7510n,TL-WA7510N,ttyS0,115200,0x75100001,1,4M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLWA801NV1,tl-wa801nd-v1,TL-WA901ND,ttyS0,115200,0x08010001,1,4M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLWA830RV1,tl-wa830re-v1,TL-WA901ND,ttyS0,115200,0x08300010,1,4M)) > @@ -2023,9 +2023,9 @@ $(eval $(call SingleProfile,TPLINK,64kraw,TLWA901NV2,tl-wa901nd-v2,TL-WA901ND-v2 > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR740NV1,tl-wr740n-v1,TL-WR741ND,ttyS0,115200,0x07400001,1,4M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR740NV3,tl-wr740n-v3,TL-WR741ND,ttyS0,115200,0x07400003,1,4M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR743NV1,tl-wr743nd-v1,TL-WR741ND,ttyS0,115200,0x07430001,1,4M)) > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV3,tl-wr841-v3,TL-WR941ND,ttyS0,115200,0x08410003,3,4M)) > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV5,tl-wr841-v5,TL-WR741ND,ttyS0,115200,0x08410005,1,4M)) > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV7,tl-wr841-v7,TL-WR841N-v7,ttyS0,115200,0x08410007,1,4M)) > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV3,tl-wr841nd-v3,TL-WR941ND,ttyS0,115200,0x08410003,3,4M)) > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV5,tl-wr841nd-v5,TL-WR741ND,ttyS0,115200,0x08410005,1,4M)) > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV7,tl-wr841nd-v7,TL-WR841N-v7,ttyS0,115200,0x08410007,1,4M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR842V1,tl-wr842n-v1,TL-MR3420,ttyS0,115200,0x08420001,1,8M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR941NV2,tl-wr941nd-v2,TL-WR941ND,ttyS0,115200,0x09410002,2,4M)) > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR941NV3,tl-wr941nd-v3,TL-WR941ND,ttyS0,115200,0x09410002,2,4M)) >
Hi John Am Sonntag, den 24.04.2016, 12:32 +0200 schrieb John Crispin: > > On 24/04/2016 10:24, Tim Niemeyer wrote: > > This reverts commit 0fd48fd7dab066db8a46e51775579c9ef507ca25. > > > > We are facing some problem on rolling out the current 15.05-branch to > > our devices because the image name changed. > > > > The changed image name breaks compatibility for derived projects and > > that's something which should only happen if there is a really good > > reason (e.g. security fix). > > > > how does it beak compatibility ? * Download links (e.g. on our wiki and who knows where else) * Upgrade scripts within our firmware -> this is the biggest problem as the running nodes are out of our control; we should handle compatible download link for a long time * Our build environment * Documentations clearing up the XXXn/XXXnd confusions. -> with the reverted change, there is even one more level of confusion. :( Yep, we have to handle all this while changing from 15.05 to the next stable. But please not within a stable release. Tim > > > > > Signed-off-by: Tim Niemeyer <tim@tn-x.org> > > --- > > > > target/linux/ar71xx/image/Makefile | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/target/linux/ar71xx/image/Makefile b/target/linux/ar71xx/image/Makefile > > index 1a399ab..9b41943 100644 > > --- a/target/linux/ar71xx/image/Makefile > > +++ b/target/linux/ar71xx/image/Makefile > > @@ -548,21 +548,21 @@ define Device/tl-wr743nd-v2 > > endef > > TARGET_DEVICES += tl-wr740n-v4 tl-wr740n-v5 tl-wr741nd-v1 tl-wr741nd-v2 tl-wr741nd-v4 tl-wr741nd-v5 tl-wr743nd-v2 > > > > -define Device/tl-wr841-v8 > > +define Device/tl-wr841n-v8 > > $(Device/tplink-4mlzma) > > BOARDNAME := TL-WR841N-v8 > > DEVICE_PROFILE := TLWR841 > > TPLINK_HWID := 0x08410008 > > endef > > > > -define Device/tl-wr841-v9 > > +define Device/tl-wr841n-v9 > > $(Device/tplink-4mlzma) > > BOARDNAME := TL-WR841N-v9 > > DEVICE_PROFILE := TLWR841 > > TPLINK_HWID := 0x08410009 > > endef > > > > -define Device/tl-wr841-v10 > > +define Device/tl-wr841n-v10 > > $(Device/tplink-4mlzma) > > BOARDNAME := TL-WR841N-v9 > > DEVICE_PROFILE := TLWR841 > > @@ -589,7 +589,7 @@ define Device/tl-wr847n-v8 > > DEVICE_PROFILE := TLWR841 > > TPLINK_HWID := 0x08470008 > > endef > > -TARGET_DEVICES += tl-wr841-v8 tl-wr841-v9 tl-wr841-v10 tl-wr842n-v2 tl-wr843nd-v1 tl-wr847n-v8 > > +TARGET_DEVICES += tl-wr841n-v8 tl-wr841n-v9 tl-wr841n-v10 tl-wr842n-v2 tl-wr843nd-v1 tl-wr847n-v8 > > > > define Device/tl-wr941nd-v5 > > $(Device/tplink-4mlzma) > > @@ -2008,13 +2008,13 @@ $(eval $(call SingleProfile,Seama,64k,QIHOO360,qihoo-c301,QIHOO-C301,ttyS0,11520 > > > > $(eval $(call SingleProfile,Senao,squashfs-only,EAP300V2,eap300v2,EAP300V2,ttyS0,115200,$$(eap300v2_mtdlayout))) > > > > -$(eval $(call SingleProfile,TPLINKOLD,squashfs-only,TLWR841NV15,tl-wr841-v1.5,TL-WR841N-v1.5,ttyS0,115200,0x08410002,2,4M)) > > +$(eval $(call SingleProfile,TPLINKOLD,squashfs-only,TLWR841NV15,tl-wr841nd-v1.5,TL-WR841N-v1.5,ttyS0,115200,0x08410002,2,4M)) > > > > $(eval $(call SingleProfile,TPLINK,64kraw,RNXN360RT,rnx-n360rt,TL-WR941ND,ttyS0,115200,0x09410002,0x00420001,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLMR3220V1,tl-mr3220-v1,TL-MR3220,ttyS0,115200,0x32200001,1,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLMR3420V1,tl-mr3420-v1,TL-MR3420,ttyS0,115200,0x34200001,1,4M)) > > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWA701NV1,tl-wa701nd-v1,TL-WA901ND,ttyS0,115200,0x07010001,1,4M)) > > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWA730REV1,tl-wa730re-v1,TL-WA901ND,ttyS0,115200,0x07300001,1,4M)) > > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWA701NV1,tl-wa701n-v1,TL-WA901ND,ttyS0,115200,0x07010001,1,4M)) > > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWA730REV1,tl-wa730rev1,TL-WA901ND,ttyS0,115200,0x07300001,1,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLWA7510NV1,tl-wa7510n,TL-WA7510N,ttyS0,115200,0x75100001,1,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLWA801NV1,tl-wa801nd-v1,TL-WA901ND,ttyS0,115200,0x08010001,1,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLWA830RV1,tl-wa830re-v1,TL-WA901ND,ttyS0,115200,0x08300010,1,4M)) > > @@ -2023,9 +2023,9 @@ $(eval $(call SingleProfile,TPLINK,64kraw,TLWA901NV2,tl-wa901nd-v2,TL-WA901ND-v2 > > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR740NV1,tl-wr740n-v1,TL-WR741ND,ttyS0,115200,0x07400001,1,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR740NV3,tl-wr740n-v3,TL-WR741ND,ttyS0,115200,0x07400003,1,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR743NV1,tl-wr743nd-v1,TL-WR741ND,ttyS0,115200,0x07430001,1,4M)) > > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV3,tl-wr841-v3,TL-WR941ND,ttyS0,115200,0x08410003,3,4M)) > > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV5,tl-wr841-v5,TL-WR741ND,ttyS0,115200,0x08410005,1,4M)) > > -$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV7,tl-wr841-v7,TL-WR841N-v7,ttyS0,115200,0x08410007,1,4M)) > > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV3,tl-wr841nd-v3,TL-WR941ND,ttyS0,115200,0x08410003,3,4M)) > > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV5,tl-wr841nd-v5,TL-WR741ND,ttyS0,115200,0x08410005,1,4M)) > > +$(eval $(call SingleProfile,TPLINK,64kraw,TLWR841NV7,tl-wr841nd-v7,TL-WR841N-v7,ttyS0,115200,0x08410007,1,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR842V1,tl-wr842n-v1,TL-MR3420,ttyS0,115200,0x08420001,1,8M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR941NV2,tl-wr941nd-v2,TL-WR941ND,ttyS0,115200,0x09410002,2,4M)) > > $(eval $(call SingleProfile,TPLINK,64kraw,TLWR941NV3,tl-wr941nd-v3,TL-WR941ND,ttyS0,115200,0x09410002,2,4M)) > > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
* John Crispin <john@phrozen.org> [25.04.2016 07:39]: > > The changed image name breaks compatibility for derived projects and > > that's something which should only happen if there is a really good > > reason (e.g. security fix). > > how does it beak compatibility ? I think they auto-download a preconfigured filename, which will ofcource not succeed. We circumvented this in our network-autoupdater in a way, that we download e.g. "$MODELNAME.bin" where $MODELNAME is from '/tmp/sysinfo/model' e.g. 'TP-Link TL-WDR4900 v1' and on the downloadserver we can "adjust" the symlinks... I'am against reverting the commit. Lets keep it, because it makes sense. Maybe i can give a short talk at Battlemesh v9 about proper autoupdates, because we have ~10 years experience in this (including 500 dead devices 8-))) bye, bastian
On 25/04/2016 08:54, Bastian Bittorf wrote: > * John Crispin <john@phrozen.org> [25.04.2016 07:39]: >>> The changed image name breaks compatibility for derived projects and >>> that's something which should only happen if there is a really good >>> reason (e.g. security fix). >> >> how does it beak compatibility ? > > I think they auto-download a preconfigured filename, > which will ofcource not succeed. We circumvented this in our > network-autoupdater in a way, that we download e.g. "$MODELNAME.bin" > where $MODELNAME is from '/tmp/sysinfo/model' e.g. 'TP-Link TL-WDR4900 v1' > and on the downloadserver we can "adjust" the symlinks... > > I'am against reverting the commit. Lets keep it, because it makes sense. > > Maybe i can give a short talk at Battlemesh v9 about proper autoupdates, > because we have ~10 years experience in this (including 500 dead devices > 8-))) > > bye, bastian > before i merged the patch i did actually look at the compat issue and concluded that only docs will be out of date, which is not really anything new. all issues mentioned are home made ones. specially the one bastian mentions here. basically fixing your download script and deploying it in this way will break forward compat as can be seen here. we now face the decision of reverting and unbreaking out of tree issues that can be fixed easily or avoided in future or not revert it and keep the fix that makes the filenames more consistent. adding the "n" is after all correct ad the antenna is not "not" detachable on the relevant models. John
Hi * Bastian Bittorf <bittorf@bluebottle.com> [25-04-16 08:54]: > * John Crispin <john@phrozen.org> [25.04.2016 07:39]: > > > The changed image name breaks compatibility for derived projects and > > > that's something which should only happen if there is a really good > > > reason (e.g. security fix). > > > > how does it beak compatibility ? > > I think they auto-download a preconfigured filename, The users are responsible for the download. They can choose between an semi automated script (coded image name, based on the board name), or a download from our site, or they can build their own, or they can use images build by derived projects. > which will ofcource not succeed. We circumvented this in our > network-autoupdater in a way, that we download e.g. "$MODELNAME.bin" > where $MODELNAME is from '/tmp/sysinfo/model' e.g. 'TP-Link TL-WDR4900 v1' > and on the downloadserver we can "adjust" the symlinks... Yes, we could change this names using filesystem links. But there is more work to do besides that e.g. documentation. We also can just revert the changes locally. But i think there are even more projects providing OpenWrt images or e.g. download links to images and they will probably also face some unexpected(!) problems. > I'am against reverting the commit. Lets keep it, because it makes sense. It totally makes sense, but it's a new feature and therefore it should be only applied to master/trunk and not to a stable branch. We use the stable branch because we don't want uncontrolled and incompatible changes! The commit which is to be reverted breaks the compatibility and doesn't bring an bug fix or an really important feature. I guess a lot of users would be even more confused by this patch, at least because some models still have an n or nd and some not. So apart from compatibility problems on the stable branch, in my opinion the feature is incomplete. But this is off topic and should be discussed separately. > Maybe i can give a short talk at Battlemesh v9 about proper autoupdates, > because we have ~10 years experience in this (including 500 dead devices > 8-))) Sorry about the dead devices. Thanks for the offer, but the automatic update is off topic and I'm currently not interested in it. Tim
This reverts commit 0fd48fd7dab066db8a46e51775579c9ef507ca25. We are facing some problem on rolling out the current 15.05-branch to our devices because the image name changed. The changed image name breaks compatibility for derived projects and that's something which should only happen if there is a really good reason (e.g. security fix). Signed-off-by: Tim Niemeyer <tim@tn-x.org> --- target/linux/ar71xx/image/Makefile | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)