fff-web: Allow minus (-) in passwords

Submitted by Adrian Schmutzler on Nov. 25, 2017, 3 p.m.

Details

Message ID 1511622016-2204-1-git-send-email-freifunk@adrianschmutzler.de
State Accepted
Headers show

Commit Message

Adrian Schmutzler Nov. 25, 2017, 3 p.m.
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

Tested-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
 src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html
index 176853a..d3287bf 100755
--- a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html
+++ b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html
@@ -4,7 +4,7 @@ 
 # write
 if [ "$REQUEST_METHOD" == "POST" ] ; then
 	#check for special characters in password
-	regex='^[a-zA-Z0-9!#\$%\(\)\*\+,\.:;=\?@\^_]+$'
+	regex='^[a-zA-Z0-9!#\$%\(\)\*\+,\.:;=\?@\^_-]+$'
 	if [ "$POST_pass1" == "" ] ; then
 		MSG='<span class="red">Das Passwort darf nicht leer sein!</span>'
     elif ! echo -n "$POST_pass1" | egrep -q "$regex"; then   

Comments

Christian Dresel Nov. 25, 2017, 3:04 p.m.
Hi

nachdem du mir im IRC bestätigt hast das auch im WebUI Login getestet zu
haben (dort gab es ja das Problem mit einigen Sonderzeichen):

Reviewed-by: Christian Dresel <fff@chrisi01.de>

mfg

Christian

On 25.11.2017 16:00, Adrian Schmutzler wrote:
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> 
> Tested-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> ---
>  src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html
> index 176853a..d3287bf 100755
> --- a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html
> +++ b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html
> @@ -4,7 +4,7 @@
>  # write
>  if [ "$REQUEST_METHOD" == "POST" ] ; then
>  	#check for special characters in password
> -	regex='^[a-zA-Z0-9!#\$%\(\)\*\+,\.:;=\?@\^_]+$'
> +	regex='^[a-zA-Z0-9!#\$%\(\)\*\+,\.:;=\?@\^_-]+$'
>  	if [ "$POST_pass1" == "" ] ; then
>  		MSG='<span class="red">Das Passwort darf nicht leer sein!</span>'
>      elif ! echo -n "$POST_pass1" | egrep -q "$regex"; then   
>
Tim Niemeyer Dec. 23, 2017, 11:55 a.m.
Hi

Reviewed und applied.

Tim

Am Samstag, den 25.11.2017, 16:00 +0100 schrieb Adrian Schmutzler:
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> 
> Tested-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> ---
>  src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff-web/files/www/ssl/cgi-
> bin/password.html b/src/packages/fff/fff-web/files/www/ssl/cgi-
> bin/password.html
> index 176853a..d3287bf 100755
> --- a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html
> +++ b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/password.html
> @@ -4,7 +4,7 @@
>  # write
>  if [ "$REQUEST_METHOD" == "POST" ] ; then
>  	#check for special characters in password
> -	regex='^[a-zA-Z0-9!#\$%\(\)\*\+,\.:;=\?@\^_]+$'
> +	regex='^[a-zA-Z0-9!#\$%\(\)\*\+,\.:;=\?@\^_-]+$'
>  	if [ "$POST_pass1" == "" ] ; then
>  		MSG='<span class="red">Das Passwort darf nicht leer
> sein!</span>'
>      elif ! echo -n "$POST_pass1" | egrep -q "$regex"; then   
> -- 
> 2.7.4
>