Use SWITCHDEV variable for mac address fixing

Submitted by Fabian Blaese on Nov. 4, 2017, 10:28 p.m.

Details

Message ID 20171104222831.2885-1-fabian@blaese.de
State Accepted
Headers show

Commit Message

Fabian Blaese Nov. 4, 2017, 10:28 p.m.
This makes use of the SWITCHDEV variable to ensure that the
correct interface is used for mac address fixing on devices,
that do not use eth0 for the switch.

Signed-off-by: Fabian Bläse <fabian@blaese.de>
---
 src/packages/fff/fff-network/files/usr/sbin/configurenetwork | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
index a60a5bf..89dd239 100755
--- a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
+++ b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
@@ -162,15 +162,15 @@  if [[ -n "$ETHMESHMAC" ]]; then
     then
         echo "MAC for ethmesh is set already"
     else
-        echo "Fixing MAC on eth0.3 (ethmesh)"
+        echo "Fixing MAC on $SWITCHDEV.3 (ethmesh)"
         sleep 10
 
         uci set network.ethmesh.macaddr=$ETHMESHMAC
         uci commit
 
-        ifconfig eth0.3 down
-        ifconfig eth0.3 hw ether $NEW_MACADDR
-        ifconfig eth0.3 up
+        ifconfig $SWITCHDEV.3 down
+        ifconfig $SWITCHDEV.3 hw ether $NEW_MACADDR
+        ifconfig $SWITCHDEV.3 up
         /etc/init.d/network restart
     fi
 fi

Comments

Christian Dresel Nov. 5, 2017, 7:52 a.m.
hi

was wir nicht alles für Sachen drinnen haben...

Reviewed-by: Christian Dresel <fff@chrisi01.de>

mfg

Christian

On 04.11.2017 23:28, Fabian Bläse wrote:
> This makes use of the SWITCHDEV variable to ensure that the
> correct interface is used for mac address fixing on devices,
> that do not use eth0 for the switch.
> 
> Signed-off-by: Fabian Bläse <fabian@blaese.de>
> ---
>  src/packages/fff/fff-network/files/usr/sbin/configurenetwork | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> index a60a5bf..89dd239 100755
> --- a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> +++ b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> @@ -162,15 +162,15 @@ if [[ -n "$ETHMESHMAC" ]]; then
>      then
>          echo "MAC for ethmesh is set already"
>      else
> -        echo "Fixing MAC on eth0.3 (ethmesh)"
> +        echo "Fixing MAC on $SWITCHDEV.3 (ethmesh)"
>          sleep 10
>  
>          uci set network.ethmesh.macaddr=$ETHMESHMAC
>          uci commit
>  
> -        ifconfig eth0.3 down
> -        ifconfig eth0.3 hw ether $NEW_MACADDR
> -        ifconfig eth0.3 up
> +        ifconfig $SWITCHDEV.3 down
> +        ifconfig $SWITCHDEV.3 hw ether $NEW_MACADDR
> +        ifconfig $SWITCHDEV.3 up
>          /etc/init.d/network restart
>      fi
>  fi
>
Tim Niemeyer Nov. 12, 2017, 4:30 p.m.
Hi

Applied.

Tim

Am Samstag, den 04.11.2017, 23:28 +0100 schrieb Fabian Bläse:
> This makes use of the SWITCHDEV variable to ensure that the
> correct interface is used for mac address fixing on devices,
> that do not use eth0 for the switch.
> 
> Signed-off-by: Fabian Bläse <fabian@blaese.de>
> ---
>  src/packages/fff/fff-network/files/usr/sbin/configurenetwork | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> index a60a5bf..89dd239 100755
> --- a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> +++ b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> @@ -162,15 +162,15 @@ if [[ -n "$ETHMESHMAC" ]]; then
>      then
>          echo "MAC for ethmesh is set already"
>      else
> -        echo "Fixing MAC on eth0.3 (ethmesh)"
> +        echo "Fixing MAC on $SWITCHDEV.3 (ethmesh)"
>          sleep 10
>  
>          uci set network.ethmesh.macaddr=$ETHMESHMAC
>          uci commit
>  
> -        ifconfig eth0.3 down
> -        ifconfig eth0.3 hw ether $NEW_MACADDR
> -        ifconfig eth0.3 up
> +        ifconfig $SWITCHDEV.3 down
> +        ifconfig $SWITCHDEV.3 hw ether $NEW_MACADDR
> +        ifconfig $SWITCHDEV.3 up
>          /etc/init.d/network restart
>      fi
>  fi
> -- 
> 2.14.2
>