[v12,5/5] fff-web: Fix style and XHTML conformity in upgrade.html

Submitted by Adrian Schmutzler on Nov. 3, 2017, 2 p.m.

Details

Message ID 1509717604-3898-5-git-send-email-freifunk@adrianschmutzler.de
State Accepted
Headers show

Commit Message

Adrian Schmutzler Nov. 3, 2017, 2 p.m. 
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

---

Changes in v12:
- Leftover from "Add downgrade interface to upgrade.html"
---
 src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox 

diff --git a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html
index a0dc5b3..af46023 100755
--- a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html
+++ b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html
@@ -32,17 +32,17 @@  fi
 <%in /www/ssl/cgi-bin/header %>
 <%in /www/ssl/cgi-bin/helpers %>
 <% show_msg %>
-<form method="POST" enctype="multipart/form-data">
+<form method="post" enctype="multipart/form-data">
 <table style="width: 100%;">
 <tr><td>
 <fieldset style="min-height: 9em;">
 	<legend>Manuelles Upgrade</legend>
 	<table>
 		<tr><th style="width: 1em;">Firmware&nbsp;Image:</th><td><input type="file" name="firmware" /></td></tr>
-		<tr><th>Konfiguration&nbsp;erhalten:</th><td><input type="checkbox" name="keep_config" checked /></td></tr>
+		<tr><th>Konfiguration&nbsp;erhalten:</th><td><input type="checkbox" name="keep_config" checked="checked" /></td></tr>
 		<tr><td colspan="2"><input type="submit" name="upgrade" value="Upgrade" /></td></tr>
 		<tr><td colspan="2"></td></tr>
-		<tr><td colspan="2">Hier kann ein Freifunk- oder OpenWrt-Image verwendet werden (*-sysupgrade.bin).</td></tr>
+		<tr><td colspan="2" style="font-style:italic">Hier kann ein Freifunk- oder OpenWrt-/LEDE-Image verwendet werden (*-sysupgrade.bin).</td></tr>
 	</table>
 </fieldset>
 </td><td>
@@ -50,7 +50,7 @@  fi
 	<legend>Router zur&uuml;cksetzen</legend>
 	<table>
 		<tr><th style="width: 1em;">Wirklich&nbsp;zur&uuml;cksetzen:</th><td>
-			<input type="checkbox" name="really_reset">
+			<input type="checkbox" name="really_reset" />
 		</td></tr>
 		<tr><td colspan="2"><input type="submit" name="reset" value="Zur&uuml;cksetzen" /></td></tr>
 		<tr><td colspan="2"></td></tr>

Comments

Christian Dresel Nov. 4, 2017, 12:32 p.m. 
Hi

sieht gut aus

Reviewed-by: Christian Dresel <fff@chrisi01.de>

P.S. Ich hab mir das als Einzelpatch eben angeguckt und kurz eingespielt
ohne die ganze Serie.

mfg

Christian

On 03.11.2017 15:00, Adrian Schmutzler wrote:
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> 
> ---
> 
> Changes in v12:
> - Leftover from "Add downgrade interface to upgrade.html"
> ---
>  src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html
> index a0dc5b3..af46023 100755
> --- a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html
> +++ b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html
> @@ -32,17 +32,17 @@ fi
>  <%in /www/ssl/cgi-bin/header %>
>  <%in /www/ssl/cgi-bin/helpers %>
>  <% show_msg %>
> -<form method="POST" enctype="multipart/form-data">
> +<form method="post" enctype="multipart/form-data">
>  <table style="width: 100%;">
>  <tr><td>
>  <fieldset style="min-height: 9em;">
>  	<legend>Manuelles Upgrade</legend>
>  	<table>
>  		<tr><th style="width: 1em;">Firmware&nbsp;Image:</th><td><input type="file" name="firmware" /></td></tr>
> -		<tr><th>Konfiguration&nbsp;erhalten:</th><td><input type="checkbox" name="keep_config" checked /></td></tr>
> +		<tr><th>Konfiguration&nbsp;erhalten:</th><td><input type="checkbox" name="keep_config" checked="checked" /></td></tr>
>  		<tr><td colspan="2"><input type="submit" name="upgrade" value="Upgrade" /></td></tr>
>  		<tr><td colspan="2"></td></tr>
> -		<tr><td colspan="2">Hier kann ein Freifunk- oder OpenWrt-Image verwendet werden (*-sysupgrade.bin).</td></tr>
> +		<tr><td colspan="2" style="font-style:italic">Hier kann ein Freifunk- oder OpenWrt-/LEDE-Image verwendet werden (*-sysupgrade.bin).</td></tr>
>  	</table>
>  </fieldset>
>  </td><td>
> @@ -50,7 +50,7 @@ fi
>  	<legend>Router zur&uuml;cksetzen</legend>
>  	<table>
>  		<tr><th style="width: 1em;">Wirklich&nbsp;zur&uuml;cksetzen:</th><td>
> -			<input type="checkbox" name="really_reset">
> +			<input type="checkbox" name="really_reset" />
>  		</td></tr>
>  		<tr><td colspan="2"><input type="submit" name="reset" value="Zur&uuml;cksetzen" /></td></tr>
>  		<tr><td colspan="2"></td></tr>
>
Tim Niemeyer Nov. 12, 2017, 4:27 p.m. 
Am Samstag, den 04.11.2017, 13:32 +0100 schrieb Christian Dresel:
> Hi
> 
> sieht gut aus
> 
> Reviewed-by: Christian Dresel <fff@chrisi01.de>

Applied

Tim

> 
> P.S. Ich hab mir das als Einzelpatch eben angeguckt und kurz eingespielt
> ohne die ganze Serie.
> 
> mfg
> 
> Christian
> 
> On 03.11.2017 15:00, Adrian Schmutzler wrote:
> > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> > 
> > ---
> > 
> > Changes in v12:
> > - Leftover from "Add downgrade interface to upgrade.html"
> > ---
> >  src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html
> > index a0dc5b3..af46023 100755
> > --- a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html
> > +++ b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/upgrade.html
> > @@ -32,17 +32,17 @@ fi
> >  <%in /www/ssl/cgi-bin/header %>
> >  <%in /www/ssl/cgi-bin/helpers %>
> >  <% show_msg %>
> > -<form method="POST" enctype="multipart/form-data">
> > +<form method="post" enctype="multipart/form-data">
> >  <table style="width: 100%;">
> >  <tr><td>
> >  <fieldset style="min-height: 9em;">
> >  	<legend>Manuelles Upgrade</legend>
> >  	<table>
> >  		<tr><th style="width: 1em;">Firmware&nbsp;Image:</th><td><input type="file" name="firmware" /></td></tr>
> > -		<tr><th>Konfiguration&nbsp;erhalten:</th><td><input type="checkbox" name="keep_config" checked /></td></tr>
> > +		<tr><th>Konfiguration&nbsp;erhalten:</th><td><input type="checkbox" name="keep_config" checked="checked" /></td></tr>
> >  		<tr><td colspan="2"><input type="submit" name="upgrade" value="Upgrade" /></td></tr>
> >  		<tr><td colspan="2"></td></tr>
> > -		<tr><td colspan="2">Hier kann ein Freifunk- oder OpenWrt-Image verwendet werden (*-sysupgrade.bin).</td></tr>
> > +		<tr><td colspan="2" style="font-style:italic">Hier kann ein Freifunk- oder OpenWrt-/LEDE-Image verwendet werden (*-sysupgrade.bin).</td></tr>
> >  	</table>
> >  </fieldset>
> >  </td><td>
> > @@ -50,7 +50,7 @@ fi
> >  	<legend>Router zur&uuml;cksetzen</legend>
> >  	<table>
> >  		<tr><th style="width: 1em;">Wirklich&nbsp;zur&uuml;cksetzen:</th><td>
> > -			<input type="checkbox" name="really_reset">
> > +			<input type="checkbox" name="really_reset" />
> >  		</td></tr>
> >  		<tr><td colspan="2"><input type="submit" name="reset" value="Zur&uuml;cksetzen" /></td></tr>
> >  		<tr><td colspan="2"></td></tr>
> > 
> 
> -- 
> franken-dev mailing list
> franken-dev@freifunk.net
> http://lists.freifunk.net/mailman/listinfo/franken-dev-freifunk.net