| Message ID | 1503146082-10812-2-git-send-email-tim@tn-x.org |
|---|---|
| State | Accepted |
| Headers | show |
diff --git a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless index a083c13..12dce84 100644 --- a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless +++ b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless @@ -23,7 +23,7 @@ wifiAddPhy() { local phy=$1 local channel=$2 - local radio="radio$(echo $phy | tr -d -C [0-9])" + local radio="radio$(echo "$phy" | tr -d -C "0-9")" local hwmode="11g" if [ "$channel" -gt "14" ]; then hwmode="11a"
Reviewed-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> Tested-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > -----Original Message----- > From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf > Of Tim Niemeyer > Sent: Samstag, 19. August 2017 14:35 > To: franken-dev@freifunk.net > Subject: [PATCH v3 2/2] fff-wireless: fix shellcheck errors > > In src/packages/fff/fff-wireless/files/lib/functions/fff/wireless line 26: > local radio="radio$(echo $phy | tr -d -C [0-9])" > ^-- SC2086: Double quote to prevent globbing and word > splitting. > ^-- SC2060: Quote parameters to tr to prevent glob > expansion. > > Signed-off-by: Tim Niemeyer <tim@tn-x.org> > --- > > Changes in v3: > - New patch > > src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > index a083c13..12dce84 100644 > --- a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > +++ b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > @@ -23,7 +23,7 @@ wifiAddPhy() { > > local phy=$1 > local channel=$2 > - local radio="radio$(echo $phy | tr -d -C [0-9])" > + local radio="radio$(echo "$phy" | tr -d -C "0-9")" > local hwmode="11g" > if [ "$channel" -gt "14" ]; then > hwmode="11a" > -- > 2.1.4 > > -- > franken-dev mailing list > franken-dev@freifunk.net > http://lists.freifunk.net/mailman/listinfo/franken-dev-freifunk.net
Hi Am Sonntag, den 17.09.2017, 16:28 +0200 schrieb mail@adrianschmutzler.de: > Reviewed-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > Tested-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> Danke! Und applied. Tim > > > -----Original Message----- > > From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On > > Behalf > > Of Tim Niemeyer > > Sent: Samstag, 19. August 2017 14:35 > > To: franken-dev@freifunk.net > > Subject: [PATCH v3 2/2] fff-wireless: fix shellcheck errors > > > > In src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > > line 26: > > local radio="radio$(echo $phy | tr -d -C [0-9])" > > ^-- SC2086: Double quote to > > prevent > > globbing and word > > splitting. > > ^-- SC2060: Quote > > parameters to tr to prevent glob > > expansion. > > > > Signed-off-by: Tim Niemeyer <tim@tn-x.org> > > --- > > > > Changes in v3: > > - New patch > > > > src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 2 > > +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > > b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > > index a083c13..12dce84 100644 > > --- a/src/packages/fff/fff- > > wireless/files/lib/functions/fff/wireless > > +++ b/src/packages/fff/fff- > > wireless/files/lib/functions/fff/wireless > > @@ -23,7 +23,7 @@ wifiAddPhy() { > > > > local phy=$1 > > local channel=$2 > > - local radio="radio$(echo $phy | tr -d -C [0-9])" > > + local radio="radio$(echo "$phy" | tr -d -C "0-9")" > > local hwmode="11g" > > if [ "$channel" -gt "14" ]; then > > hwmode="11a" > > -- > > 2.1.4 > > > > -- > > franken-dev mailing list > > franken-dev@freifunk.net > > http://lists.freifunk.net/mailman/listinfo/franken-dev-freifunk.net > >
In src/packages/fff/fff-wireless/files/lib/functions/fff/wireless line 26: local radio="radio$(echo $phy | tr -d -C [0-9])" ^-- SC2086: Double quote to prevent globbing and word splitting. ^-- SC2060: Quote parameters to tr to prevent glob expansion. Signed-off-by: Tim Niemeyer <tim@tn-x.org> --- Changes in v3: - New patch src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)