[v4,07/11] WebUI: Partially fix XHTML conformity in settings.html

Submitted by Adrian Schmutzler on July 21, 2017, 1:08 p.m.

Details

Message ID 1500642529-3627-8-git-send-email-freifunk@adrianschmutzler.de
State Accepted
Headers show

Commit Message

Adrian Schmutzler July 21, 2017, 1:08 p.m.
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

Tested-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
 src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html
index a3fbcd5..2ccc756 100755
--- a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html
+++ b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html
@@ -51,13 +51,13 @@  fi
 <%
 # read
 if [ "$(uci -q get 'fff.@trafficcontrol[0].enabled')" == "1" ] ; then
-	traffic_checked="checked"
+	traffic_checked='checked="checked" '
 else
 	traffic_checked=""
 fi
 %>
 <% show_msg %>
-<form method="POST">
+<form method="post">
 <table style="width: 100%;">
 <tr><td>
 <fieldset style="min-height: 13em;">
@@ -81,7 +81,7 @@  fi
 	<legend>Bitratenbegrenzung</legend>
 	<table>
 		<tr><th>Aktiviert:</th><td colspan="2">
-			<input type="checkbox" name="traffic_limit" <%= ${traffic_checked} %>>
+			<input type="checkbox" name="traffic_limit" <%= ${traffic_checked} %>/>
 		</td></tr>
 		<tr><th>Freifunk&nbsp;Download:</th><td><input type="text" name="limit_ingress" value="<%= $(uci -q get 'fff.@trafficcontrol[0].limit_in') %>" /></td><td>kbit/s</td></tr>
 		<tr><th>Freifunk&nbsp;Upload:</th><td><input type="text" name="limit_egress" value="<%= $(uci -q get 'fff.@trafficcontrol[0].limit_out') %>" /></td><td>kbit/s</td></tr>
@@ -89,6 +89,6 @@  fi
 </fieldset>
 </td></tr>
 </table>
-<input type="submit" style="margin-top: 5px; margin-left: 3px;" />
+<p><input type="submit" style="margin-top: 5px; margin-left: 3px;" /></p>
 </form>
 <%in /www/ssl/cgi-bin/footer %>

Comments

Christian Dresel Aug. 20, 2017, 10:15 a.m.
hi

sieht gut aus

Reviewed-by: Christian Dresel <fff@chrisi01.de>

mfg

Christian

On 21.07.2017 15:08, Adrian Schmutzler wrote:
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> 
> Tested-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> ---
>  src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html
> index a3fbcd5..2ccc756 100755
> --- a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html
> +++ b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html
> @@ -51,13 +51,13 @@ fi
>  <%
>  # read
>  if [ "$(uci -q get 'fff.@trafficcontrol[0].enabled')" == "1" ] ; then
> -	traffic_checked="checked"
> +	traffic_checked='checked="checked" '
>  else
>  	traffic_checked=""
>  fi
>  %>
>  <% show_msg %>
> -<form method="POST">
> +<form method="post">
>  <table style="width: 100%;">
>  <tr><td>
>  <fieldset style="min-height: 13em;">
> @@ -81,7 +81,7 @@ fi
>  	<legend>Bitratenbegrenzung</legend>
>  	<table>
>  		<tr><th>Aktiviert:</th><td colspan="2">
> -			<input type="checkbox" name="traffic_limit" <%= ${traffic_checked} %>>
> +			<input type="checkbox" name="traffic_limit" <%= ${traffic_checked} %>/>
>  		</td></tr>
>  		<tr><th>Freifunk&nbsp;Download:</th><td><input type="text" name="limit_ingress" value="<%= $(uci -q get 'fff.@trafficcontrol[0].limit_in') %>" /></td><td>kbit/s</td></tr>
>  		<tr><th>Freifunk&nbsp;Upload:</th><td><input type="text" name="limit_egress" value="<%= $(uci -q get 'fff.@trafficcontrol[0].limit_out') %>" /></td><td>kbit/s</td></tr>
> @@ -89,6 +89,6 @@ fi
>  </fieldset>
>  </td></tr>
>  </table>
> -<input type="submit" style="margin-top: 5px; margin-left: 3px;" />
> +<p><input type="submit" style="margin-top: 5px; margin-left: 3px;" /></p>
>  </form>
>  <%in /www/ssl/cgi-bin/footer %>
>
Tim Niemeyer Aug. 20, 2017, 12:19 p.m.
Hi

Rebased und applied.

Tim

Am Sonntag, den 20.08.2017, 12:15 +0200 schrieb Christian Dresel:
> hi
> 
> sieht gut aus
> 
> Reviewed-by: Christian Dresel <fff@chrisi01.de>
> 
> mfg
> 
> Christian
> 
> On 21.07.2017 15:08, Adrian Schmutzler wrote:
> > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> > 
> > Tested-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> > ---
> >  src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html | 8
> > ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/src/packages/fff/fff-web/files/www/ssl/cgi-
> > bin/settings.html b/src/packages/fff/fff-web/files/www/ssl/cgi-
> > bin/settings.html
> > index a3fbcd5..2ccc756 100755
> > --- a/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html
> > +++ b/src/packages/fff/fff-web/files/www/ssl/cgi-bin/settings.html
> > @@ -51,13 +51,13 @@ fi
> >  <%
> >  # read
> >  if [ "$(uci -q get 'fff.@trafficcontrol[0].enabled')" == "1" ] ;
> > then
> > -	traffic_checked="checked"
> > +	traffic_checked='checked="checked" '
> >  else
> >  	traffic_checked=""
> >  fi
> >  %>
> >  <% show_msg %>
> > -<form method="POST">
> > +<form method="post">
> >  <table style="width: 100%;">
> >  <tr><td>
> >  <fieldset style="min-height: 13em;">
> > @@ -81,7 +81,7 @@ fi
> >  	<legend>Bitratenbegrenzung</legend>
> >  	<table>
> >  		<tr><th>Aktiviert:</th><td colspan="2">
> > -			<input type="checkbox"
> > name="traffic_limit" <%= ${traffic_checked} %>>
> > +			<input type="checkbox"
> > name="traffic_limit" <%= ${traffic_checked} %>/>
> >  		</td></tr>
> >  		<tr><th>Freifunk&nbsp;Download:</th><td><input
> > type="text" name="limit_ingress" value="<%= $(uci -q get 'fff.@traf
> > ficcontrol[0].limit_in') %>" /></td><td>kbit/s</td></tr>
> >  		<tr><th>Freifunk&nbsp;Upload:</th><td><input
> > type="text" name="limit_egress" value="<%= $(uci -q get 'fff.@traff
> > iccontrol[0].limit_out') %>" /></td><td>kbit/s</td></tr>
> > @@ -89,6 +89,6 @@ fi
> >  </fieldset>
> >  </td></tr>
> >  </table>
> > -<input type="submit" style="margin-top: 5px; margin-left: 3px;" />
> > +<p><input type="submit" style="margin-top: 5px; margin-left: 3px;"
> > /></p>
> >  </form>
> >  <%in /www/ssl/cgi-bin/footer %>
> > 
> 
>