fff-macnock: clean up package variables

Submitted by Adrian Schmutzler on April 22, 2020, 5:38 p.m.

Details

Message ID 20200422173841.5284-1-freifunk@adrianschmutzler.de
State Accepted
Headers show

Commit Message

Adrian Schmutzler April 22, 2020, 5:38 p.m. 
This removes unnecessary package variables and rearranges the
remaining ones based on the common style in OpenWrt trunk.

In particular, this drops PKG_VERSION in favor of PKG_SOURCE_DATE,
since it does not seem reasonable to tag a version every time we
want to pull it. Despite, while we effectively pull via the
variable PKG_SOURCE_VERSION anyway, the PKG_VERSION might even
have hidden changes if not properly adjusted.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

---

Not tested.
---
 src/packages/fff/fff-macnock/Makefile | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Patch hide | download patch | download mbox 

diff --git a/src/packages/fff/fff-macnock/Makefile b/src/packages/fff/fff-macnock/Makefile
index 0e45b38a..ae53d3fe 100644
--- a/src/packages/fff/fff-macnock/Makefile
+++ b/src/packages/fff/fff-macnock/Makefile
@@ -1,15 +1,12 @@ 
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=fff-macnock
-PKG_VERSION:=0.1
 PKG_RELEASE:=1
-PKG_REV:=ffd1a64515709d75afaab0f990308fd164dc4cc6
 
-PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
-PKG_SOURCE_URL:=https://github.com/FreifunkFranken/macnocker.git
 PKG_SOURCE_PROTO:=git
-PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION)
-PKG_SOURCE_VERSION:=$(PKG_REV)
+PKG_SOURCE_URL:=https://github.com/FreifunkFranken/macnocker.git
+PKG_SOURCE_DATE:=2018-04-03
+PKG_SOURCE_VERSION:=ffd1a64515709d75afaab0f990308fd164dc4cc6
 
 include $(INCLUDE_DIR)/package.mk
 include $(INCLUDE_DIR)/cmake.mk

Comments

Fabian Blaese April 23, 2020, 9:48 a.m. 
Reviewed-by: Fabian Bläse <fabian@blaese.de>
Fabian Blaese April 23, 2020, 10:07 a.m. 
applied