[v2,5/5] bsp: Increase .config readability by introducing blocks

Submitted by Adrian Schmutzler on June 3, 2019, 11:15 a.m.

Details

Message ID 20190603111549.2709-5-freifunk@adrianschmutzler.de
State Rejected
Headers show

Commit Message

Adrian Schmutzler June 3, 2019, 11:15 a.m. 
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
 bsp/ar71xx/.config  | 12 ++++++++----
 bsp/wdr4900/.config |  4 +++-
 2 files changed, 11 insertions(+), 5 deletions(-)

Patch hide | download patch | download mbox 

diff --git a/bsp/ar71xx/.config b/bsp/ar71xx/.config
index e92bb44d..b4c96c9e 100644
--- a/bsp/ar71xx/.config
+++ b/bsp/ar71xx/.config
@@ -4,6 +4,8 @@ 
 CONFIG_TARGET_ar71xx=y
 CONFIG_TARGET_ar71xx_tiny=y
 CONFIG_TARGET_MULTI_PROFILE=y
+CONFIG_TARGET_PER_DEVICE_ROOTFS=y
+
 CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_archer-c25-v1=y
 CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_archer-c25-v1="-kmod-ath10k kmod-ath10k-ct"
 CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_archer-c60-v1=y
@@ -76,14 +78,13 @@  CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_ubnt-unifi=y
 CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_ubnt-unifi=""
 CONFIG_TARGET_DEVICE_ar71xx_tiny_DEVICE_ubnt-unifiac-lite=y
 CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_tiny_DEVICE_ubnt-unifiac-lite="-kmod-ath10k kmod-ath10k-ct"
+
 CONFIG_BUSYBOX_CUSTOM=y
-CONFIG_TARGET_PER_DEVICE_ROOTFS=y
 # CONFIG_BUSYBOX_CONFIG_BRCTL is not set
 # CONFIG_BUSYBOX_CONFIG_CROND is not set
 # CONFIG_BUSYBOX_CONFIG_CRONTAB is not set
 # CONFIG_BUSYBOX_CONFIG_FEATURE_FAST_TOP is not set
 # CONFIG_BUSYBOX_CONFIG_FEATURE_NTPD_SERVER is not set
-CONFIG_CLEAN_IPKG=y
 # CONFIG_DROPBEAR_CURVE25519 is not set
 # CONFIG_FASTD_ENABLE_CIPHER_SALSA2012 is not set
 # CONFIG_FASTD_ENABLE_MAC_GHASH is not set
@@ -95,10 +96,13 @@  CONFIG_CLEAN_IPKG=y
 # CONFIG_KERNEL_DEBUG_INFO is not set
 # CONFIG_KERNEL_DEBUG_KERNEL is not set
 # CONFIG_PACKAGE_ALFRED_VIS is not set
+CONFIG_PACKAGE_kmod-hwmon-core=m
+CONFIG_PACKAGE_opkg=m
+
 CONFIG_PACKAGE_ath10k-firmware-qca9887-ct=m
 CONFIG_PACKAGE_ath10k-firmware-qca988x-ct=m
 CONFIG_PACKAGE_kmod-ath10k-ct=m
-CONFIG_PACKAGE_kmod-hwmon-core=m
-CONFIG_PACKAGE_opkg=m
+
+CONFIG_CLEAN_IPKG=y
 CONFIG_STRIP_KERNEL_EXPORTS=y
 CONFIG_TARGET_SQUASHFS_BLOCK_SIZE=512
diff --git a/bsp/wdr4900/.config b/bsp/wdr4900/.config
index 29774c60..3699f80e 100644
--- a/bsp/wdr4900/.config
+++ b/bsp/wdr4900/.config
@@ -4,13 +4,13 @@ 
 CONFIG_TARGET_mpc85xx=y
 CONFIG_TARGET_mpc85xx_generic=y
 CONFIG_TARGET_mpc85xx_generic_Default=y
+
 CONFIG_BUSYBOX_CUSTOM=y
 # CONFIG_BUSYBOX_CONFIG_BRCTL is not set
 # CONFIG_BUSYBOX_CONFIG_CROND is not set
 # CONFIG_BUSYBOX_CONFIG_CRONTAB is not set
 # CONFIG_BUSYBOX_CONFIG_FEATURE_FAST_TOP is not set
 # CONFIG_BUSYBOX_CONFIG_FEATURE_NTPD_SERVER is not set
-CONFIG_CLEAN_IPKG=y
 # CONFIG_DROPBEAR_CURVE25519 is not set
 # CONFIG_FASTD_ENABLE_CIPHER_SALSA2012 is not set
 # CONFIG_FASTD_ENABLE_MAC_GHASH is not set
@@ -23,5 +23,7 @@  CONFIG_CLEAN_IPKG=y
 # CONFIG_KERNEL_DEBUG_KERNEL is not set
 # CONFIG_PACKAGE_ALFRED_VIS is not set
 # CONFIG_PACKAGE_opkg is not set
+
+CONFIG_CLEAN_IPKG=y
 CONFIG_STRIP_KERNEL_EXPORTS=y
 CONFIG_TARGET_SQUASHFS_BLOCK_SIZE=512

Comments

Fabian Blaese June 4, 2019, 2:11 p.m. 
Hallo Adrian,

Ehrlichgesagt finde ich das so nicht wirklich besser, denn das macht einen diff zu dem was menuconfig ausspuckt nicht grade kürzer.
Dafür ist der Gewinn bei der Lesbarkeit imho zu klein.

Gruß
Fabian