| Message ID | 20190205135603.2020-1-freifunk@adrianschmutzler.de |
|---|---|
| State | Accepted |
| Headers | show |
diff --git a/buildscript b/buildscript index 1d527c6e..9cf45cd2 100755 --- a/buildscript +++ b/buildscript @@ -293,9 +293,6 @@ cp_firmware() { image_factory=${image/sysupgrade/factory$region} if [[ -f "$target/bin/targets/${chipset}/${subtarget}/$image_factory" ]]; then filename_build_factory=${filename_build/sysupgrade/factory$region} - if [ ${#image_factory} -lt ${#filename_build_factory} ]; then - echo "Warning: The factory image file name (${filename_build_factory}) is longer than the OpenWrt one, which might lead to incompatibility with the stock firmware." - fi cp "$target/bin/targets/${chipset}/${subtarget}/$image_factory" "./bin/$filename_build_factory" fi done
Tatsächlich sind bei den betroffenen Geräten häufig auch die OpenWRT Namen zu lang. Reviewed-by: Fabian Bläse <fabian@blaese.de> Gruß Fabian On 05.02.19 14:56, Adrian Schmutzler wrote: > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > > --- > > I personally never considered this warning helpful, as building > and flashing are typically separated processes. > --- > buildscript | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/buildscript b/buildscript > index 1d527c6e..9cf45cd2 100755 > --- a/buildscript > +++ b/buildscript > @@ -293,9 +293,6 @@ cp_firmware() { > image_factory=${image/sysupgrade/factory$region} > if [[ -f "$target/bin/targets/${chipset}/${subtarget}/$image_factory" ]]; then > filename_build_factory=${filename_build/sysupgrade/factory$region} > - if [ ${#image_factory} -lt ${#filename_build_factory} ]; then > - echo "Warning: The factory image file name (${filename_build_factory}) is longer than the OpenWrt one, which might lead to incompatibility with the stock firmware." > - fi > cp "$target/bin/targets/${chipset}/${subtarget}/$image_factory" "./bin/$filename_build_factory" > fi > done >
Applied.
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> --- I personally never considered this warning helpful, as building and flashing are typically separated processes. --- buildscript | 3 --- 1 file changed, 3 deletions(-)