[2/2] buildscript: Show success messages for copied images

Submitted by Adrian Schmutzler on Feb. 5, 2019, 1:56 p.m.

Details

Message ID 20190205135603.2020-2-freifunk@adrianschmutzler.de
State Rejected
Headers show

Commit Message

Adrian Schmutzler Feb. 5, 2019, 1:56 p.m. 
This will print one line for each successfully build image.
With this patch, it is much easier to see whether builds were
successful.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
 buildscript | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox 

diff --git a/buildscript b/buildscript
index 9cf45cd2..084b8be7 100755
--- a/buildscript
+++ b/buildscript
@@ -287,13 +287,15 @@  cp_firmware() {
         filename_build=${filename_build//generic/g}
         filename_build=${filename_build//tiny/t}
         filename_build=${filename_build//squashfs-/}
-        cp "$target/bin/targets/${chipset}/${subtarget}/$image" "./bin/$filename_build"
+        cp "$target/bin/targets/${chipset}/${subtarget}/$image" "./bin/$filename_build" && \
+        echo "Success: $filename_build"
 
         for region in "" "-eu" "-us"; do
             image_factory=${image/sysupgrade/factory$region}
             if [[ -f "$target/bin/targets/${chipset}/${subtarget}/$image_factory" ]]; then
               filename_build_factory=${filename_build/sysupgrade/factory$region}
-              cp "$target/bin/targets/${chipset}/${subtarget}/$image_factory" "./bin/$filename_build_factory"
+              cp "$target/bin/targets/${chipset}/${subtarget}/$image_factory" "./bin/$filename_build_factory" && \
+              echo "Success: $filename_build_factory"
             fi
         done
     done

Comments

Fabian Blaese May 31, 2019, 5:05 p.m. 
Würde ich nicht so machen.

Viel wichtiger finde ich dass man sieht, wenn etwas nicht gebaut hat.
Das ist durch die Fehlermeldung vom cp ja schon der Fall.

Gruß
Fabian

On 05.02.19 14:56, Adrian Schmutzler wrote:
> This will print one line for each successfully build image.
> With this patch, it is much easier to see whether builds were
> successful.
> 
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> ---
>  buildscript | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/buildscript b/buildscript
> index 9cf45cd2..084b8be7 100755
> --- a/buildscript
> +++ b/buildscript
> @@ -287,13 +287,15 @@ cp_firmware() {
>          filename_build=${filename_build//generic/g}
>          filename_build=${filename_build//tiny/t}
>          filename_build=${filename_build//squashfs-/}
> -        cp "$target/bin/targets/${chipset}/${subtarget}/$image" "./bin/$filename_build"
> +        cp "$target/bin/targets/${chipset}/${subtarget}/$image" "./bin/$filename_build" && \
> +        echo "Success: $filename_build"
>  
>          for region in "" "-eu" "-us"; do
>              image_factory=${image/sysupgrade/factory$region}
>              if [[ -f "$target/bin/targets/${chipset}/${subtarget}/$image_factory" ]]; then
>                filename_build_factory=${filename_build/sysupgrade/factory$region}
> -              cp "$target/bin/targets/${chipset}/${subtarget}/$image_factory" "./bin/$filename_build_factory"
> +              cp "$target/bin/targets/${chipset}/${subtarget}/$image_factory" "./bin/$filename_build_factory" && \
> +              echo "Success: $filename_build_factory"
>              fi
>          done
>      done
>