Message ID | 20181126214953.26663-1-fabian@blaese.de |
---|---|
State | Accepted |
Headers | show |
diff --git a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless index abbfc93..2473e09 100644 --- a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless +++ b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless @@ -57,8 +57,7 @@ wifiAddPhy() { __EOF__ if [ "$hwmode" = "11g" ]; then uci batch <<-__EOF__ - set wireless.${radio}.supported_rates='6000 9000 12000 18000 24000 36000 48000 54000' - set wireless.${radio}.basic_rate='6000 9000 18000 36000 54000' + set wireless.${radio}.legacy_rates='0' __EOF__ fi uci commit wireless
hi sieht gut aus, danke. Reviewed-by: Christian Dresel <fff@chrisi01.de> mfg Christian Am 26.11.18 um 22:49 schrieb Fabian Bläse: > Instead of manually overwriting basic and supported rates, > this patch makes use of a new OpenWRT option "legacy_rates", > which disables 802.11b data rates. > > Signed-off-by: Fabian Bläse <fabian@blaese.de> > --- > src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > index abbfc93..2473e09 100644 > --- a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > +++ b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > @@ -57,8 +57,7 @@ wifiAddPhy() { > __EOF__ > if [ "$hwmode" = "11g" ]; then > uci batch <<-__EOF__ > - set wireless.${radio}.supported_rates='6000 9000 12000 18000 24000 36000 48000 54000' > - set wireless.${radio}.basic_rate='6000 9000 18000 36000 54000' > + set wireless.${radio}.legacy_rates='0' > __EOF__ > fi > uci commit wireless >
Dass sollte man vor einem Release noch gut testen. Wollt ihr das drinnen haben? From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of Christian Dresel Sent: Dienstag, 27. November 2018 14:45 To: Fabian Bläse <fabian@blaese.de>; franken-dev@freifunk.net Subject: Re: [PATCH] Disable 802.11b rates using OpenWRT option hi sieht gut aus, danke. Reviewed-by: Christian Dresel <fff@chrisi01.de <mailto:fff@chrisi01.de> > mfg Christian Am 26.11.18 um 22:49 schrieb Fabian Bläse: > Instead of manually overwriting basic and supported rates, > this patch makes use of a new OpenWRT option "legacy_rates", > which disables 802.11b data rates. > > Signed-off-by: Fabian Bläse <fabian@blaese.de <mailto:fabian@blaese.de> > > --- > src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > index abbfc93..2473e09 100644 > --- a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > +++ b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > @@ -57,8 +57,7 @@ wifiAddPhy() { > __EOF__ > if [ "$hwmode" = "11g" ]; then > uci batch <<-__EOF__ > - set wireless.${radio}.supported_rates='6000 9000 12000 18000 24000 36000 48000 54000' > - set wireless.${radio}.basic_rate='6000 9000 18000 36000 54000' > + set wireless.${radio}.legacy_rates='0' > __EOF__ > fi > uci commit wireless >
hi habs eben "getestet" auf der Firtzbox, der hostapd schreibt da genau das gleiche in seine config file wie zuvor die alte support/basic Dinge: Neu: root@fritzbox-test:~# cat /tmp/run/hostapd-phy0.conf [...] supported_rates=60 90 120 180 240 360 480 540 basic_rates=60 120 240 [...] Alt: root@fritzbox-test:~# cat /tmp/run/hostapd-phy0.conf [...] supported_rates=60 90 120 180 240 360 480 540 basic_rates=60 90 180 360 540 [...] ok es werden bissle ander rates verwendet, sollte im großen und ganzen aber keinen Unterschied machen. Das Netz funtkioniert bei nem kurzen Test einwandfrei Da ich es nicht allgemein für alle Geräte testen kann, ist mir ein tested-by auch bissle zu heikel. Gehe aber sehr stark davon aus das es tut (und sonst fällt es hoffentlich in der beta auf ;)) mfg Christian Am 27.11.18 um 14:49 schrieb Adrian Schmutzler: > Dass sollte man vor einem Release noch gut testen. Wollt ihr das drinnen > haben? > > > > *From:*franken-dev [mailto:franken-dev-bounces@freifunk.net] *On Behalf > Of *Christian Dresel > *Sent:* Dienstag, 27. November 2018 14:45 > *To:* Fabian Bläse <fabian@blaese.de>; franken-dev@freifunk.net > *Subject:* Re: [PATCH] Disable 802.11b rates using OpenWRT option > > > > hi > > sieht gut aus, danke. > > Reviewed-by: Christian Dresel <fff@chrisi01.de <mailto:fff@chrisi01.de>> > > mfg > > Christian > > Am 26.11.18 um 22:49 schrieb Fabian Bläse: >> Instead of manually overwriting basic and supported rates, >> this patch makes use of a new OpenWRT option "legacy_rates", >> which disables 802.11b data rates. >> >> Signed-off-by: Fabian Bläse <fabian@blaese.de <mailto:fabian@blaese.de>> >> --- >> src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > >> index abbfc93..2473e09 100644 >> --- a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> +++ b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> @@ -57,8 +57,7 @@ wifiAddPhy() { >> __EOF__ >> if [ "$hwmode" = "11g" ]; then >> uci batch <<-__EOF__ >> - set wireless.${radio}.supported_rates='6000 9000 12000 18000 24000 36000 48000 54000' >> - set wireless.${radio}.basic_rate='6000 9000 18000 36000 54000' >> + set wireless.${radio}.legacy_rates='0' >> __EOF__ >> fi >> uci commit wireless >> > > >
Soll der noch mit rein (Christian meinte ja, ich habe ein bisschen Angst)? > -----Original Message----- > From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf > Of Fabian Bläse > Sent: Montag, 26. November 2018 22:50 > To: franken-dev@freifunk.net > Subject: [PATCH] Disable 802.11b rates using OpenWRT option > > Instead of manually overwriting basic and supported rates, this patch makes > use of a new OpenWRT option "legacy_rates", which disables 802.11b data > rates. > > Signed-off-by: Fabian Bläse <fabian@blaese.de> > --- > src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > index abbfc93..2473e09 100644 > --- a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > +++ b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless > @@ -57,8 +57,7 @@ wifiAddPhy() { > __EOF__ > if [ "$hwmode" = "11g" ]; then > uci batch <<-__EOF__ > - set wireless.${radio}.supported_rates='6000 9000 > 12000 18000 24000 36000 48000 54000' > - set wireless.${radio}.basic_rate='6000 9000 18000 > 36000 54000' > + set wireless.${radio}.legacy_rates='0' > __EOF__ > fi > uci commit wireless > -- > 2.19.1
Mir solls egal sein, das Verhalten bleibt nahezu identisch. Ich sehe grade allerdings nicht, wovor man dabei Angst haben sollte. Gruß Fabian On 27.11.18 23:24, mail@adrianschmutzler.de wrote: > Soll der noch mit rein (Christian meinte ja, ich habe ein bisschen Angst)? > >> -----Original Message----- >> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf >> Of Fabian Bläse >> Sent: Montag, 26. November 2018 22:50 >> To: franken-dev@freifunk.net >> Subject: [PATCH] Disable 802.11b rates using OpenWRT option >> >> Instead of manually overwriting basic and supported rates, this patch makes >> use of a new OpenWRT option "legacy_rates", which disables 802.11b data >> rates. >> >> Signed-off-by: Fabian Bläse <fabian@blaese.de> >> --- >> src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> index abbfc93..2473e09 100644 >> --- a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> +++ b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> @@ -57,8 +57,7 @@ wifiAddPhy() { >> __EOF__ >> if [ "$hwmode" = "11g" ]; then >> uci batch <<-__EOF__ >> - set wireless.${radio}.supported_rates='6000 9000 >> 12000 18000 24000 36000 48000 54000' >> - set wireless.${radio}.basic_rate='6000 9000 18000 >> 36000 54000' >> + set wireless.${radio}.legacy_rates='0' >> __EOF__ >> fi >> uci commit wireless >> -- >> 2.19.1
Naja, die Frage ist halt, ob er wirklich das tut, was er soll. Als wir das erste Mal b abgeschaltet haben, wurde da recht lange diskutiert und getestet. Aber wenn ihr das beide für unproblematisch erachtet, dann applye ich den jetzt. Gibt keine extra Mail mehr. Grüße Adrian From: Fabian Bläse [mailto:fabian@blaese.de] Sent: Dienstag, 27. November 2018 23:30 To: mail@adrianschmutzler.de; franken-dev@freifunk.net Subject: Re: [PATCH] Disable 802.11b rates using OpenWRT option Mir solls egal sein, das Verhalten bleibt nahezu identisch. Ich sehe grade allerdings nicht, wovor man dabei Angst haben sollte. Gruß Fabian On 27.11.18 23:24, mail@adrianschmutzler.de <mailto:mail@adrianschmutzler.de> wrote: > Soll der noch mit rein (Christian meinte ja, ich habe ein bisschen Angst)? > >> -----Original Message----- >> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf >> Of Fabian Bläse >> Sent: Montag, 26. November 2018 22:50 >> To: franken-dev@freifunk.net <mailto:franken-dev@freifunk.net> >> Subject: [PATCH] Disable 802.11b rates using OpenWRT option >> >> Instead of manually overwriting basic and supported rates, this patch makes >> use of a new OpenWRT option "legacy_rates", which disables 802.11b data >> rates. >> >> Signed-off-by: Fabian Bläse <fabian@blaese.de <mailto:fabian@blaese.de> > >> --- >> src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> index abbfc93..2473e09 100644 >> --- a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> +++ b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless >> @@ -57,8 +57,7 @@ wifiAddPhy() { >> __EOF__ >> if [ "$hwmode" = "11g" ]; then >> uci batch <<-__EOF__ >> - set wireless.${radio}.supported_rates='6000 9000 >> 12000 18000 24000 36000 48000 54000' >> - set wireless.${radio}.basic_rate='6000 9000 18000 >> 36000 54000' >> + set wireless.${radio}.legacy_rates='0' >> __EOF__ >> fi >> uci commit wireless >> -- >> 2.19.1
Instead of manually overwriting basic and supported rates, this patch makes use of a new OpenWRT option "legacy_rates", which disables 802.11b data rates. Signed-off-by: Fabian Bläse <fabian@blaese.de> --- src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)