network: set router solicitations to default value

Submitted by Fabian Blaese on Nov. 26, 2018, 5:54 p.m.

Details

Message ID 20181126175422.23820-1-fabian@blaese.de
State Accepted
Headers show

Commit Message

Fabian Blaese Nov. 26, 2018, 5:54 p.m.
When setting up a node, router solicitations can be used to speed
up receiving router advertisements a lot. This mechanism has been
previously disabled by our custom sysctl config.

However because linux does not send router solicitations, if it
doesn't accept router advertisements, which is disabled for every
link except WAN, this option can safely be set to it's default value
for all interfaces.
---
 .../fff/fff-network/files/etc/sysctl.d/50-fff-network.conf   | 5 -----
 1 file changed, 5 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
index c4b4396..d6a6751 100644
--- a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
+++ b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
@@ -39,11 +39,6 @@  net.ipv6.conf.all.accept_dad=0
 net.ipv6.conf.all.accept_ra=0
 net.ipv6.conf.all.accept_redirects=0
 
-# Number of Router Solicitations to send until assuming no routers are present.
-# This is host and not router
-net.ipv6.conf.default.router_solicitations = 0
-net.ipv6.conf.all.router_solicitations = 0
- 
 # Accept Router Preference in RA?
 net.ipv6.conf.default.accept_ra_rtr_pref = 0
 net.ipv6.conf.all.accept_ra_rtr_pref = 0

Comments

Fabian Blaese Nov. 26, 2018, 7:12 p.m.
Signed-off-by: Fabian Bläse <fabian@blaese.de>

On 26.11.18 18:54, Fabian Bläse wrote:
> When setting up a node, router solicitations can be used to speed
> up receiving router advertisements a lot. This mechanism has been
> previously disabled by our custom sysctl config.
> 
> However because linux does not send router solicitations, if it
> doesn't accept router advertisements, which is disabled for every
> link except WAN, this option can safely be set to it's default value
> for all interfaces.
> ---
>  .../fff/fff-network/files/etc/sysctl.d/50-fff-network.conf   | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
> index c4b4396..d6a6751 100644
> --- a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
> +++ b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
> @@ -39,11 +39,6 @@ net.ipv6.conf.all.accept_dad=0
>  net.ipv6.conf.all.accept_ra=0
>  net.ipv6.conf.all.accept_redirects=0
>  
> -# Number of Router Solicitations to send until assuming no routers are present.
> -# This is host and not router
> -net.ipv6.conf.default.router_solicitations = 0
> -net.ipv6.conf.all.router_solicitations = 0
> - 
>  # Accept Router Preference in RA?
>  net.ipv6.conf.default.accept_ra_rtr_pref = 0
>  net.ipv6.conf.all.accept_ra_rtr_pref = 0
>
Robert Langhammer Nov. 27, 2018, 9:56 a.m.
Hallo Fabian,

ich hab mal nachgeschaut. Das kam 2012 so rein mit "Do not accept RAs
and other stuff" ( 16f1b7c8d418db7a3f349 ) und wurde dann so mitgeschleppt.

Guter Fund!

Reviewed-by: Robert Langhammer <rlanghammer@web.de>

Am 26.11.18 um 20:12 schrieb Fabian Bläse:
> Signed-off-by: Fabian Bläse <fabian@blaese.de>
>
> On 26.11.18 18:54, Fabian Bläse wrote:
>> When setting up a node, router solicitations can be used to speed
>> up receiving router advertisements a lot. This mechanism has been
>> previously disabled by our custom sysctl config.
>>
>> However because linux does not send router solicitations, if it
>> doesn't accept router advertisements, which is disabled for every
>> link except WAN, this option can safely be set to it's default value
>> for all interfaces.
>> ---
>>  .../fff/fff-network/files/etc/sysctl.d/50-fff-network.conf   | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
>> index c4b4396..d6a6751 100644
>> --- a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
>> +++ b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
>> @@ -39,11 +39,6 @@ net.ipv6.conf.all.accept_dad=0
>>  net.ipv6.conf.all.accept_ra=0
>>  net.ipv6.conf.all.accept_redirects=0
>>  
>> -# Number of Router Solicitations to send until assuming no routers are present.
>> -# This is host and not router
>> -net.ipv6.conf.default.router_solicitations = 0
>> -net.ipv6.conf.all.router_solicitations = 0
>> - 
>>  # Accept Router Preference in RA?
>>  net.ipv6.conf.default.accept_ra_rtr_pref = 0
>>  net.ipv6.conf.all.accept_ra_rtr_pref = 0
>>
Christian Dresel Nov. 27, 2018, 2:25 p.m.
hi

sieht soweit schlüssig aus, danke :)

Reviewed-by: Christian Dresel <fff@chrisi01.de>

mfg

Christian

Am 26.11.18 um 20:12 schrieb Fabian Bläse:
> Signed-off-by: Fabian Bläse <fabian@blaese.de>
> 
> On 26.11.18 18:54, Fabian Bläse wrote:
>> When setting up a node, router solicitations can be used to speed
>> up receiving router advertisements a lot. This mechanism has been
>> previously disabled by our custom sysctl config.
>>
>> However because linux does not send router solicitations, if it
>> doesn't accept router advertisements, which is disabled for every
>> link except WAN, this option can safely be set to it's default value
>> for all interfaces.
>> ---
>>  .../fff/fff-network/files/etc/sysctl.d/50-fff-network.conf   | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
>> index c4b4396..d6a6751 100644
>> --- a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
>> +++ b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
>> @@ -39,11 +39,6 @@ net.ipv6.conf.all.accept_dad=0
>>  net.ipv6.conf.all.accept_ra=0
>>  net.ipv6.conf.all.accept_redirects=0
>>  
>> -# Number of Router Solicitations to send until assuming no routers are present.
>> -# This is host and not router
>> -net.ipv6.conf.default.router_solicitations = 0
>> -net.ipv6.conf.all.router_solicitations = 0
>> - 
>>  # Accept Router Preference in RA?
>>  net.ipv6.conf.default.accept_ra_rtr_pref = 0
>>  net.ipv6.conf.all.accept_ra_rtr_pref = 0
>>
>
Adrian Schmutzler Nov. 27, 2018, 10:24 p.m.
Applied.

> -----Original Message-----
> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf
> Of Fabian Bläse
> Sent: Montag, 26. November 2018 18:54
> To: franken-dev@freifunk.net
> Subject: [PATCH] network: set router solicitations to default value
> 
> When setting up a node, router solicitations can be used to speed up
> receiving router advertisements a lot. This mechanism has been previously
> disabled by our custom sysctl config.
> 
> However because linux does not send router solicitations, if it doesn't accept
> router advertisements, which is disabled for every link except WAN, this
> option can safely be set to it's default value for all interfaces.
> ---
>  .../fff/fff-network/files/etc/sysctl.d/50-fff-network.conf   | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-
> network.conf b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-
> network.conf
> index c4b4396..d6a6751 100644
> --- a/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.conf
> +++ b/src/packages/fff/fff-network/files/etc/sysctl.d/50-fff-network.con
> +++ f
> @@ -39,11 +39,6 @@ net.ipv6.conf.all.accept_dad=0
>  net.ipv6.conf.all.accept_ra=0
>  net.ipv6.conf.all.accept_redirects=0
> 
> -# Number of Router Solicitations to send until assuming no routers are
> present.
> -# This is host and not router
> -net.ipv6.conf.default.router_solicitations = 0 -
> net.ipv6.conf.all.router_solicitations = 0
> -
>  # Accept Router Preference in RA?
>  net.ipv6.conf.default.accept_ra_rtr_pref = 0
> net.ipv6.conf.all.accept_ra_rtr_pref = 0
> --
> 2.19.1