| Message ID | 20181110221702.19549-1-fabian@blaese.de |
|---|---|
| State | Accepted |
| Headers | show |
diff --git a/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select b/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select index ddd21a1..58e48c4 100755 --- a/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select +++ b/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select @@ -26,7 +26,7 @@ do echo "key \"${key}\";" >> "$filename" json_get_var address address json_get_var port port - echo "remote ipv4 \"${address}\" port ${port};" >> "$filename" + echo "remote \"${address}\" port ${port};" >> "$filename" echo "" >> "$filename" echo "float yes;" >> "$filename"
hi Reviewed-by: Christian Dresel <fff@chrisi01.de> mfg Christian Am 10.11.18 um 23:17 schrieb Fabian Bläse: > The "ipv4" option is used to enforce using ipv4 when > using dns for fastd remotes. > However this option was incorrectly always set which > makes ipv6 connections impossible. > Because enforcing ipv4 is not necessary, this option > is removed. > > Signed-off-by: Fabian Bläse <fabian@blaese.de> > --- > src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select b/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select > index ddd21a1..58e48c4 100755 > --- a/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select > +++ b/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select > @@ -26,7 +26,7 @@ do > echo "key \"${key}\";" >> "$filename" > json_get_var address address > json_get_var port port > - echo "remote ipv4 \"${address}\" port ${port};" >> "$filename" > + echo "remote \"${address}\" port ${port};" >> "$filename" > echo "" >> "$filename" > echo "float yes;" >> "$filename" > >
Hi Ah, .. das kommt aus der Historie.. Ganz früher ging wirklich nur IPv4. Dann konnte fastd mehr und wir haben das nie angepasst. Reviewed-by: Tim Niemeyer <tim@tn-x.org> Tim Am Samstag, den 10.11.2018, 23:17 +0100 schrieb Fabian Bläse: > The "ipv4" option is used to enforce using ipv4 when > using dns for fastd remotes. > However this option was incorrectly always set which > makes ipv6 connections impossible. > Because enforcing ipv4 is not necessary, this option > is removed. > > Signed-off-by: Fabian Bläse <fabian@blaese.de> > --- > src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn- > select b/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select > index ddd21a1..58e48c4 100755 > --- a/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select > +++ b/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select > @@ -26,7 +26,7 @@ do > echo "key \"${key}\";" >> "$filename" > json_get_var address address > json_get_var port port > - echo "remote ipv4 \"${address}\" port ${port};" >> > "$filename" > + echo "remote \"${address}\" port ${port};" >> > "$filename" > echo "" >> "$filename" > echo "float yes;" >> "$filename" >
Hallo, das hat bestimmt jemand getestet, kann hier jemand ein Tested-by: schicken? Grüße Adrian From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of Christian Dresel Sent: Samstag, 10. November 2018 23:21 To: franken-dev@freifunk.net Subject: Re: [PATCH] fastd: Allow IPv6 remotes for peers hi Reviewed-by: Christian Dresel <fff@chrisi01.de <mailto:fff@chrisi01.de> > mfg Christian Am 10.11.18 um 23:17 schrieb Fabian Bläse: > The "ipv4" option is used to enforce using ipv4 when > using dns for fastd remotes. > However this option was incorrectly always set which > makes ipv6 connections impossible. > Because enforcing ipv4 is not necessary, this option > is removed. > > Signed-off-by: Fabian Bläse <fabian@blaese.de <mailto:fabian@blaese.de> > > --- > src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select b/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select > index ddd21a1..58e48c4 100755 > --- a/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select > +++ b/src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select > @@ -26,7 +26,7 @@ do > echo "key \"${key}\";" >> "$filename" > json_get_var address address > json_get_var port port > - echo "remote ipv4 \"${address}\" port ${port};" >> "$filename" > + echo "remote \"${address}\" port ${port};" >> "$filename" > echo "" >> "$filename" > echo "float yes;" >> "$filename" > >
Tested-by: Fabian Bläse <fabian@blaese.de> Fabian On 11.11.18 12:31, mail@adrianschmutzler.de wrote: > Hallo, > > > > das hat bestimmt jemand getestet, kann hier jemand ein Tested-by: schicken? > > > > Grüße > > > > Adrian
Applied. From: Fabian Bläse [mailto:fabian@blaese.de] Sent: Sonntag, 11. November 2018 12:35 To: mail@adrianschmutzler.de; franken-dev@freifunk.net Subject: Re: [PATCH] fastd: Allow IPv6 remotes for peers Tested-by: Fabian Bläse <fabian@blaese.de <mailto:fabian@blaese.de> > Fabian On 11.11.18 12:31, mail@adrianschmutzler.de <mailto:mail@adrianschmutzler.de> wrote: > Hallo, > > > > das hat bestimmt jemand getestet, kann hier jemand ein Tested-by: schicken? > > > > Grüße > > > > Adrian
The "ipv4" option is used to enforce using ipv4 when using dns for fastd remotes. However this option was incorrectly always set which makes ipv6 connections impossible. Because enforcing ipv4 is not necessary, this option is removed. Signed-off-by: Fabian Bläse <fabian@blaese.de> --- src/packages/fff/fff-vpn-select/files/usr/sbin/vpn-select | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)