configurenetwork: Improve output when setting IPv6 addresses

Submitted by Adrian Schmutzler on Jan. 2, 2018, 11:36 p.m.

Details

Message ID 1514936163-49142-1-git-send-email-freifunk@adrianschmutzler.de
State Changes Requested
Headers show

Commit Message

Adrian Schmutzler Jan. 2, 2018, 11:36 p.m.
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---
 src/packages/fff/fff-network/files/usr/sbin/configurenetwork | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
index 17e78db..ef8dee1 100755
--- a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
+++ b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
@@ -152,10 +152,11 @@  if [ -n "$ROUTERMAC" ]; then
     fixMac "$ROUTERMAC" "br-mesh" "mesh"
 fi
 
-if uci get network.mesh.ip6addr
+if uci -q get "network.mesh.ip6addr" > /dev/null
 then
     echo "IPv6 for mesh is set already"
 else
+    echo "Setting IPv6 addresses"
     # Some time needed :(
     sleep 5
 

Comments

Tim Niemeyer Jan. 20, 2018, 12:27 p.m.
Hi

Reviewed-by: Tim Niemeyer <tim@tn-x.org>

Tim

Am Mittwoch, den 03.01.2018, 00:36 +0100 schrieb Adrian Schmutzler:
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> ---
>  src/packages/fff/fff-network/files/usr/sbin/configurenetwork | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff-
> network/files/usr/sbin/configurenetwork b/src/packages/fff/fff-
> network/files/usr/sbin/configurenetwork
> index 17e78db..ef8dee1 100755
> --- a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> +++ b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> @@ -152,10 +152,11 @@ if [ -n "$ROUTERMAC" ]; then
>      fixMac "$ROUTERMAC" "br-mesh" "mesh"
>  fi
>  
> -if uci get network.mesh.ip6addr
> +if uci -q get "network.mesh.ip6addr" > /dev/null
>  then
>      echo "IPv6 for mesh is set already"
>  else
> +    echo "Setting IPv6 addresses"
>      # Some time needed :(
>      sleep 5
>  
> -- 
> 2.7.4
>
Fabian Blaese Feb. 2, 2018, 9:42 a.m.
Hallo zusammen,

Reviewed-by: Fabian Bläse <fabian@blaese.de>

Fabian

> On 20. Jan 2018, at 13:27, Tim Niemeyer <tim@tn-x.org> wrote:
> 
> Hi
> 
> Reviewed-by: Tim Niemeyer <tim@tn-x.org>
> 
> Tim
> 
> Am Mittwoch, den 03.01.2018, 00:36 +0100 schrieb Adrian Schmutzler:
>> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
>> ---
>>  src/packages/fff/fff-network/files/usr/sbin/configurenetwork | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/src/packages/fff/fff-
>> network/files/usr/sbin/configurenetwork b/src/packages/fff/fff-
>> network/files/usr/sbin/configurenetwork
>> index 17e78db..ef8dee1 100755
>> --- a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
>> +++ b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
>> @@ -152,10 +152,11 @@ if [ -n "$ROUTERMAC" ]; then
>>      fixMac "$ROUTERMAC" "br-mesh" "mesh"
>>  fi
>> 
>> -if uci get network.mesh.ip6addr
>> +if uci -q get "network.mesh.ip6addr" > /dev/null
>>  then
>>      echo "IPv6 for mesh is set already"
>>  else
>> +    echo "Setting IPv6 addresses"
>>      # Some time needed :(
>>      sleep 5
>> 
>> --
>> 2.7.4
> --
> franken-dev mailing list
> franken-dev@freifunk.net
> http://lists.freifunk.net/mailman/listinfo/franken-dev-freifunk.net
Tim Niemeyer June 17, 2018, 8:38 a.m.
Hi

Rebase needed...

Tim

Am Mittwoch, den 03.01.2018, 00:36 +0100 schrieb Adrian Schmutzler:
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
> ---
>  src/packages/fff/fff-network/files/usr/sbin/configurenetwork | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff-
> network/files/usr/sbin/configurenetwork b/src/packages/fff/fff-
> network/files/usr/sbin/configurenetwork
> index 17e78db..ef8dee1 100755
> --- a/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> +++ b/src/packages/fff/fff-network/files/usr/sbin/configurenetwork
> @@ -152,10 +152,11 @@ if [ -n "$ROUTERMAC" ]; then
>      fixMac "$ROUTERMAC" "br-mesh" "mesh"
>  fi
>  
> -if uci get network.mesh.ip6addr
> +if uci -q get "network.mesh.ip6addr" > /dev/null
>  then
>      echo "IPv6 for mesh is set already"
>  else
> +    echo "Setting IPv6 addresses"
>      # Some time needed :(
>      sleep 5
>  
> -- 
> 2.7.4
>