alfred-proxy: Make curl silent

Submitted by Fabian Blaese on June 14, 2020, 11:17 a.m.

Details

Message ID 20200614111705.481189-1-fabian@blaese.de
State Accepted
Headers show

Commit Message

Fabian Blaese June 14, 2020, 11:17 a.m.
As we now log output of cron scripts to syslog, the debug
output of curl spams the rather short-lived syslog. As this
debug output is unessesary most of the time, it now is disabled.

Instead, curl's silent option is used, together with '-S', which
reenables error output.

Signed-off-by: Fabian Bläse <fabian@blaese.de>
---
 .../files/usr/sbin/alfred-monitoring-proxy                      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred-monitoring-proxy b/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred-monitoring-proxy
index d2c2f61..8b241f6 100755
--- a/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred-monitoring-proxy
+++ b/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred-monitoring-proxy
@@ -4,4 +4,4 @@  api_url="https://monitoring.freifunk-franken.de/api/alfred2"
 fetch_id="64"
 
 /bin/alfred-json -r "$fetch_id" | \
-    /usr/bin/curl -k -v -H "Content-type: application/json; charset=UTF-8" --data-binary @- "$api_url"
+    /usr/bin/curl -k -sS -H "Content-type: application/json; charset=UTF-8" --data-binary @- "$api_url"

Comments

Robert Langhammer June 17, 2020, 7 a.m.
Hi,

ist mir noch gar nicht aufgefallen :) Aber ja.

Reviewed-by: Robert Langhammer <rlanghammer@web.de>

Am 14.06.20 um 13:17 schrieb Fabian Bläse:
> As we now log output of cron scripts to syslog, the debug
> output of curl spams the rather short-lived syslog. As this
> debug output is unessesary most of the time, it now is disabled.
>
> Instead, curl's silent option is used, together with '-S', which
> reenables error output.
>
> Signed-off-by: Fabian Bläse <fabian@blaese.de>
> ---
>  .../files/usr/sbin/alfred-monitoring-proxy                      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred-monitoring-proxy b/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred-monitoring-proxy
> index d2c2f61..8b241f6 100755
> --- a/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred-monitoring-proxy
> +++ b/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred-monitoring-proxy
> @@ -4,4 +4,4 @@ api_url="https://monitoring.freifunk-franken.de/api/alfred2"
>  fetch_id="64"
>
>  /bin/alfred-json -r "$fetch_id" | \
> -    /usr/bin/curl -k -v -H "Content-type: application/json; charset=UTF-8" --data-binary @- "$api_url"
> +    /usr/bin/curl -k -sS -H "Content-type: application/json; charset=UTF-8" --data-binary @- "$api_url"
Adrian Schmutzler June 18, 2020, 10:21 a.m.
Hallo,

Reviewed-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
Tested-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

Im Erfolgsfall bekomme ich immer noch ein "{}" als Ausgabe.

Wird gleich gemergt, auch hier werde ich das PKG_RELEASE erhöhen.

Grüße

Adrian

> -----Original Message-----
> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf
> Of Fabian Bläse
> Sent: Sonntag, 14. Juni 2020 13:17
> To: franken-dev@freifunk.net
> Subject: [PATCH] alfred-proxy: Make curl silent
> 
> As we now log output of cron scripts to syslog, the debug output of curl
> spams the rather short-lived syslog. As this debug output is unessesary most
> of the time, it now is disabled.
> 
> Instead, curl's silent option is used, together with '-S', which reenables error
> output.
> 
> Signed-off-by: Fabian Bläse <fabian@blaese.de>
> ---
>  .../files/usr/sbin/alfred-monitoring-proxy                      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff-alfred-monitoring-
> proxy/files/usr/sbin/alfred-monitoring-proxy b/src/packages/fff/fff-alfred-
> monitoring-proxy/files/usr/sbin/alfred-monitoring-proxy
> index d2c2f61..8b241f6 100755
> --- a/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred-
> monitoring-proxy
> +++ b/src/packages/fff/fff-alfred-monitoring-proxy/files/usr/sbin/alfred
> +++ -monitoring-proxy
> @@ -4,4 +4,4 @@ api_url="https://monitoring.freifunk-
> franken.de/api/alfred2"
>  fetch_id="64"
> 
>  /bin/alfred-json -r "$fetch_id" | \
> -    /usr/bin/curl -k -v -H "Content-type: application/json; charset=UTF-8" --
> data-binary @- "$api_url"
> +    /usr/bin/curl -k -sS -H "Content-type: application/json; charset=UTF-8" --
> data-binary @- "$api_url"
> --
> 2.27.0
Fabian Blaese June 18, 2020, 10:22 a.m.
> Im Erfolgsfall bekomme ich immer noch ein "{}" als Ausgabe.
Das ist der Content vom Monitoring. Man könnte da noch ein >/dev/null dazu packen, wenn man möchte.

Gruß
Fabian