Message ID | 20200426191632.19788-1-rlanghammer@web.de |
---|---|
State | New |
Headers | show |
diff --git a/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway b/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway index 5230888..bef7af6 100755 --- a/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway +++ b/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway @@ -14,10 +14,6 @@ # DO NOT RUN THIS IN CRONJOB! execute_subshell() { - if [ $# -ne 1 ]; then - echo "Usage:" "$0" "<function>" - fi - for script in /etc/gateway.d/*; do ( # unset function to prevent executing parents shell function
Hmm. Fehlerbehandlung weg patchen ist irgendwie immer so eine Sache. Sollte man diese Funktion doch irgendwann noch mal brauchen, wenn man etwas neues entwickelt, dann könnte man da schon auf die Nase fallen. Ich bin hier etwas unentschlossen. Was meinen die anderen? Gruß Fabian On 26.04.20 21:16, Robert Langhammer wrote: > The parametertest of execute_subshell() will never fail. All calls are hardcoded! It can be removed. > > Signed-off-by: Robert Langhammer <rlanghammer@web.de> > --- > src/packages/fff/fff-gateway/files/usr/sbin/configuregateway | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway b/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway > index 5230888..bef7af6 100755 > --- a/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway > +++ b/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway > @@ -14,10 +14,6 @@ > # DO NOT RUN THIS IN CRONJOB! > > execute_subshell() { > - if [ $# -ne 1 ]; then > - echo "Usage:" "$0" "<function>" > - fi > - > for script in /etc/gateway.d/*; do > ( > # unset function to prevent executing parents shell function > -- > 2.20.1 >
The parametertest of execute_subshell() will never fail. All calls are hardcoded! It can be removed. Signed-off-by: Robert Langhammer <rlanghammer@web.de> --- src/packages/fff/fff-gateway/files/usr/sbin/configuregateway | 4 ---- 1 file changed, 4 deletions(-) -- 2.20.1