fff-hoods: Add missing dependencies

Submitted by Fabian Blaese on April 26, 2020, 11:08 a.m.

Details

Message ID 20200426110836.132982-1-fabian@blaese.de
State Superseded
Headers show

Commit Message

Fabian Blaese April 26, 2020, 11:08 a.m.
The configurehood script unconditionally sources various
libraries from other packages, which previously have not
been included in the fff-hoods package dependencies.

Add the missing dependencies to fff-network, fff-wireless,
fff-timeserver and libubox (jshn.sh).

Signed-off-by: Fabian Bläse <fabian@blaese.de>
---
 src/packages/fff/fff-hoods/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/packages/fff/fff-hoods/Makefile b/src/packages/fff/fff-hoods/Makefile
index e5680c2..49d912b 100644
--- a/src/packages/fff/fff-hoods/Makefile
+++ b/src/packages/fff/fff-hoods/Makefile
@@ -1,7 +1,7 @@ 
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=fff-hoods
-PKG_RELEASE:=9
+PKG_RELEASE:=10
 
 PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)
 
@@ -13,6 +13,7 @@  define Package/$(PKG_NAME)
 	TITLE:= Freifunk-Franken hoods
 	URL:=http://www.freifunk-franken.de
 	DEPENDS:=+fff-hoodutils +fff-macnock +fff-vpn-select +fff-firewall \
+			 +fff-timeserver +fff-network +fff-wireless +libubox \
 			 +@BUSYBOX_CONFIG_WGET +@BUSYBOX_CONFIG_FEATURE_WGET_TIMEOUT
 endef
 

Comments

Adrian Schmutzler April 28, 2020, 10:07 a.m.
Hi,

sorry for being late.

> -----Original Message-----
> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf
> Of Fabian Bläse
> Sent: Sonntag, 26. April 2020 13:09
> To: franken-dev@freifunk.net
> Subject: [PATCH] fff-hoods: Add missing dependencies
> 
> The configurehood script unconditionally sources various libraries from other
> packages, which previously have not been included in the fff-hoods package
> dependencies.
> 
> Add the missing dependencies to fff-network, fff-wireless, fff-timeserver
> and libubox (jshn.sh).
> 
> Signed-off-by: Fabian Bläse <fabian@blaese.de>
> ---
>  src/packages/fff/fff-hoods/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff-hoods/Makefile b/src/packages/fff/fff-
> hoods/Makefile
> index e5680c2..49d912b 100644
> --- a/src/packages/fff/fff-hoods/Makefile
> +++ b/src/packages/fff/fff-hoods/Makefile
> @@ -1,7 +1,7 @@
>  include $(TOPDIR)/rules.mk
> 
>  PKG_NAME:=fff-hoods
> -PKG_RELEASE:=9
> +PKG_RELEASE:=10
> 
>  PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)
> 
> @@ -13,6 +13,7 @@ define Package/$(PKG_NAME)
>  	TITLE:= Freifunk-Franken hoods
>  	URL:=http://www.freifunk-franken.de
>  	DEPENDS:=+fff-hoodutils +fff-macnock +fff-vpn-select +fff-firewall \
> +			 +fff-timeserver +fff-network +fff-wireless +libubox \

Why libubox?

Best

Adrian

>  			 +@BUSYBOX_CONFIG_WGET
> +@BUSYBOX_CONFIG_FEATURE_WGET_TIMEOUT
>  endef
> 
> --
> 2.26.2
Fabian Blaese April 28, 2020, 10:12 a.m.
Hi Adrian,

On 28.04.20 12:07, mail@adrianschmutzler.de wrote:
> Hi,
> 
> sorry for being late.
> 
>> @@ -13,6 +13,7 @@ define Package/$(PKG_NAME)
>>  	TITLE:= Freifunk-Franken hoods
>>  	URL:=http://www.freifunk-franken.de
>>  	DEPENDS:=+fff-hoodutils +fff-macnock +fff-vpn-select +fff-firewall \
>> +			 +fff-timeserver +fff-network +fff-wireless +libubox \
> 
> Why libubox?
Because jshn.sh is included and used in configuregateaway, which is part of the libubox package.

Regards,
Fabian
Adrian Schmutzler April 28, 2020, 10:19 a.m.
Hallo,

installiert wird die Datei aber als Teil von jshn:

https://github.com/openwrt/openwrt/blob/955634b473284847e3c8281a6ac85655329d8b06/package/libs/libubox/Makefile#L80

Also bräuchte wir eigtl. +jshn (wird bei OpenWrt durch den netifd gezogen).

Grüße

Adrian
Fabian Blaese April 28, 2020, 10:27 a.m.
Hmm. Stimmt wohl.
Da muss dann wohl eine v2 her.

Gruß
Fabian