| Message ID | 20200425175114.2152-2-freifunk@adrianschmutzler.de |
|---|---|
| State | Superseded |
| Headers | show |
diff --git a/src/packages/fff/fff-gateway/files/etc/gateway.d/01-version b/src/packages/fff/fff-gateway/files/etc/gateway.d/01-version index 9d303223..6758fa81 100644 --- a/src/packages/fff/fff-gateway/files/etc/gateway.d/01-version +++ b/src/packages/fff/fff-gateway/files/etc/gateway.d/01-version @@ -10,6 +10,12 @@ configure() { fi # check version of configuration + if ! [ -n "$config_version" ]; then + echo "ERROR: No config version given. Supported versions: '1'" + + exit 1 + fi + if [ "$config_version" != "$expected_version" ]; then echo "ERROR: Invalid config version. Expected '$expected_version', got '$config_version'." echo "Please check what has been changed and adjust your config appropriately."
Reviewed-by: Fabian Bläse <fabian@blaese.de>
Hallo Adrian, gibt es einen speziellen Grund, warum du expected_version nicht verwendet hast? Ich würde das gerne nicht doppelt haben, sonst vergessen wir irgendwann mal eins von beiden. Gruß Fabian
This explicitly checks whether the config version is set at all, instead of just comparing it, and provides a specific error message for that case. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> --- src/packages/fff/fff-gateway/files/etc/gateway.d/01-version | 6 ++++++ 1 file changed, 6 insertions(+)