From patchwork Wed Apr 22 18:03:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2] fff-macnock: clean up package variables From: Adrian Schmutzler X-Patchwork-Id: 1363 Message-Id: <20200422180300.14712-1-freifunk@adrianschmutzler.de> To: franken-dev@freifunk.net Date: Wed, 22 Apr 2020 20:03:00 +0200 This removes unnecessary package variables and rearranges the remaining ones based on the common style in OpenWrt trunk. In particular, this drops PKG_VERSION in favor of PKG_SOURCE_DATE, since it does not seem reasonable to tag a version every time we want to pull it. Despite, while we effectively pull via the variable PKG_SOURCE_VERSION anyway, the PKG_VERSION might even have hidden changes if not properly adjusted. This also adds the PKG_MIRROR_HASH commonly used for OpenWrt packages. After having changed the PKG_SOURCE_VERSION, it can be easily created by: make package/fff-macnock/download make package/fff-macnock/check V=s FIXUP=1 Signed-off-by: Adrian Schmutzler --- Not tested. Changes in v2: added PKG_MIRROR_HASH --- src/packages/fff/fff-macnock/Makefile | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/packages/fff/fff-macnock/Makefile b/src/packages/fff/fff-macnock/Makefile index 0e45b38a..7ed5c83e 100644 --- a/src/packages/fff/fff-macnock/Makefile +++ b/src/packages/fff/fff-macnock/Makefile @@ -1,15 +1,13 @@ include $(TOPDIR)/rules.mk PKG_NAME:=fff-macnock -PKG_VERSION:=0.1 PKG_RELEASE:=1 -PKG_REV:=ffd1a64515709d75afaab0f990308fd164dc4cc6 -PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2 -PKG_SOURCE_URL:=https://github.com/FreifunkFranken/macnocker.git PKG_SOURCE_PROTO:=git -PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION) -PKG_SOURCE_VERSION:=$(PKG_REV) +PKG_SOURCE_URL:=https://github.com/FreifunkFranken/macnocker.git +PKG_SOURCE_DATE:=2018-04-03 +PKG_SOURCE_VERSION:=ffd1a64515709d75afaab0f990308fd164dc4cc6 +PKG_MIRROR_HASH:=f0c251399613c86b505312d87b4132b4eaf0b1a910b9a6503b9d82ab5056978d include $(INCLUDE_DIR)/package.mk include $(INCLUDE_DIR)/cmake.mk