From patchwork Fri Apr 17 12:21:13 2020
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: buildscript: check selected_bsp link target
From: Adrian Schmutzler <freifunk@adrianschmutzler.de>
X-Patchwork-Id: 1343
Message-Id: <20200417122113.1458-1-freifunk@adrianschmutzler.de>
To: franken-dev@freifunk.net
Date: Fri, 17 Apr 2020 14:21:13 +0200

While buildscript checks whether selected_bsp exists, it does not
verify whether it is pointing to a sensible direction.

Since we use the target file name and content to derive build folders
etc., though, this patch adds a check and exits the script if the
link is broken.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
Reviewed-by: Fabian Bläse <fabian@blaese.de>
---
 buildscript | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/buildscript b/buildscript
index d2da0e30..9f6217c2 100755
--- a/buildscript
+++ b/buildscript
@@ -360,7 +360,14 @@ clean() {
 
 loadBSP()
 {
-    echo "Working with $(/bin/ls -l selected_bsp | awk '{ print $11 }')"
+    localbsppath=$(/bin/ls -l selected_bsp | awk '{ print $11 }')
+
+    if ! [ -s selected_bsp ]; then
+        echo "Error: $localbsppath does not exist. Aborting ..."
+        exit 1
+    fi
+
+    echo "Working with $localbsppath"
     . selected_bsp
     machine=$(basename $(realpath selected_bsp) .bsp)
 }