| Message ID | 20191210161438.1273-1-freifunk@adrianschmutzler.de |
|---|---|
| State | Superseded |
| Headers | show |
diff --git a/src/packages/fff/fff-sysupgrade/Makefile b/src/packages/fff/fff-sysupgrade/Makefile index 0e6c08ec..0f2e6a1e 100644 --- a/src/packages/fff/fff-sysupgrade/Makefile +++ b/src/packages/fff/fff-sysupgrade/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=fff-sysupgrade -PKG_RELEASE:=10 +PKG_RELEASE:=11 PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME) diff --git a/src/packages/fff/fff-sysupgrade/files/etc/sysupgrade.sh b/src/packages/fff/fff-sysupgrade/files/bin/fffupdate.sh similarity index 100% rename from src/packages/fff/fff-sysupgrade/files/etc/sysupgrade.sh rename to src/packages/fff/fff-sysupgrade/files/bin/fffupdate.sh
> The old name "sysupgrade.sh" is easy to be confused with OpenWrt's > /sbin/sysupgrade. Rename our script to clearly indicate it's > purpose. it's -> its
Hi Adrian, da stimme ich dir zu! Über den Namen könnte man noch diskutieren - wenn man möchte. z.B. /bin/fff-sysupgrade Reviewed-by: Robert Langhammer <rlanghammer@web.de> Am 10.12.19 um 17:14 schrieb Adrian Schmutzler: > The old name "sysupgrade.sh" is easy to be confused with OpenWrt's > /sbin/sysupgrade. Rename our script to clearly indicate it's > purpose. > > While at it, move from /etc to /bin, as the former is an odd location > for an executable script. > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > --- > src/packages/fff/fff-sysupgrade/Makefile | 2 +- > .../files/{etc/sysupgrade.sh => bin/fffupdate.sh} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename src/packages/fff/fff-sysupgrade/files/{etc/sysupgrade.sh => bin/fffupdate.sh} (100%) > > diff --git a/src/packages/fff/fff-sysupgrade/Makefile b/src/packages/fff/fff-sysupgrade/Makefile > index 0e6c08ec..0f2e6a1e 100644 > --- a/src/packages/fff/fff-sysupgrade/Makefile > +++ b/src/packages/fff/fff-sysupgrade/Makefile > @@ -1,7 +1,7 @@ > include $(TOPDIR)/rules.mk > > PKG_NAME:=fff-sysupgrade > -PKG_RELEASE:=10 > +PKG_RELEASE:=11 > > PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME) > > diff --git a/src/packages/fff/fff-sysupgrade/files/etc/sysupgrade.sh b/src/packages/fff/fff-sysupgrade/files/bin/fffupdate.sh > similarity index 100% > rename from src/packages/fff/fff-sysupgrade/files/etc/sysupgrade.sh > rename to src/packages/fff/fff-sysupgrade/files/bin/fffupdate.sh
Hallo zusammen, mir würde ein Name, der "Upgrade" statt update enhält, mehr zusagen. Der Vorschlag von Robert gefällt mir eigentlich gut. Weiterhin sollte das Skript wohl eher nach /usr/sbin (oder /sbin). Wär cool, wenn man das noch ändern könnte. Ansonsten Reviewed-by: Fabian Bläse <fabian@blaese.de> Gruß Fabian On 10.12.19 18:01, robert wrote: > Hi Adrian, > > da stimme ich dir zu! > > Über den Namen könnte man noch diskutieren - wenn man möchte. z.B. > /bin/fff-sysupgrade > > Reviewed-by: Robert Langhammer <rlanghammer@web.de> > > Am 10.12.19 um 17:14 schrieb Adrian Schmutzler: >> The old name "sysupgrade.sh" is easy to be confused with OpenWrt's >> /sbin/sysupgrade. Rename our script to clearly indicate it's >> purpose. >> >> While at it, move from /etc to /bin, as the former is an odd location >> for an executable script. >> >> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> >> --- >> src/packages/fff/fff-sysupgrade/Makefile | 2 +- >> .../files/{etc/sysupgrade.sh => bin/fffupdate.sh} | 0 >> 2 files changed, 1 insertion(+), 1 deletion(-) >> rename src/packages/fff/fff-sysupgrade/files/{etc/sysupgrade.sh => bin/fffupdate.sh} (100%) >> >> diff --git a/src/packages/fff/fff-sysupgrade/Makefile b/src/packages/fff/fff-sysupgrade/Makefile >> index 0e6c08ec..0f2e6a1e 100644 >> --- a/src/packages/fff/fff-sysupgrade/Makefile >> +++ b/src/packages/fff/fff-sysupgrade/Makefile >> @@ -1,7 +1,7 @@ >> include $(TOPDIR)/rules.mk >> >> PKG_NAME:=fff-sysupgrade >> -PKG_RELEASE:=10 >> +PKG_RELEASE:=11 >> >> PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME) >> >> diff --git a/src/packages/fff/fff-sysupgrade/files/etc/sysupgrade.sh b/src/packages/fff/fff-sysupgrade/files/bin/fffupdate.sh >> similarity index 100% >> rename from src/packages/fff/fff-sysupgrade/files/etc/sysupgrade.sh >> rename to src/packages/fff/fff-sysupgrade/files/bin/fffupdate.sh >
The old name "sysupgrade.sh" is easy to be confused with OpenWrt's /sbin/sysupgrade. Rename our script to clearly indicate it's purpose. While at it, move from /etc to /bin, as the former is an odd location for an executable script. Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> --- src/packages/fff/fff-sysupgrade/Makefile | 2 +- .../files/{etc/sysupgrade.sh => bin/fffupdate.sh} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename src/packages/fff/fff-sysupgrade/files/{etc/sysupgrade.sh => bin/fffupdate.sh} (100%)