| Message ID | 20191119140627.2593-2-freifunk@adrianschmutzler.de |
|---|---|
| State | Accepted |
| Headers | show |
diff --git a/src/packages/fff/fff-wireless/Makefile b/src/packages/fff/fff-wireless/Makefile index 9b7b4d3f..5ae864ab 100644 --- a/src/packages/fff/fff-wireless/Makefile +++ b/src/packages/fff/fff-wireless/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=fff-wireless -PKG_RELEASE:=9 +PKG_RELEASE:=10 PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME) diff --git a/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless b/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless index cb057c2d..a51fe7ab 100644 --- a/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless +++ b/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless @@ -43,9 +43,11 @@ esac # rssileds case "$BOARD" in + cpe210|\ cpe210-v2|\ - cpe210-v3) - uci -q set system.rssid_wlan0.dev=radio0 - uci -q commit system + cpe210-v3|\ + cpe510|\ + tl-wa850re-v1) + /etc/init.d/rssileds disable ;; esac
Reviewed-by: Christian Dresel <fff@chrisi01.de> On 19.11.19 15:06, Adrian Schmutzler wrote: > The rssileds set up by OpenWrt cannot be used in our firmware. > Despite that those are bound to "wlan0" initially, we also cannot > change them to one of our interfaces, as the interface recreation > due to configurehood seems to break something in rssileds, causing > high load. > > This patch now disables the rssileds entirely, which has been found > to be the only solution reliably solving the problem of high load > under all circumstances. > > While at it, add all remaining devices with rssileds enabled in > openwrt-18.06. (When updating to openwrt-19.07, most of the ubnt > will have to be added.) > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > > --- > > This is the result of testing by several people and has been used > successfully for several months. > --- > src/packages/fff/fff-wireless/Makefile | 2 +- > .../files/etc/uci-defaults/62-config-wireless | 8 +++++--- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/packages/fff/fff-wireless/Makefile b/src/packages/fff/fff-wireless/Makefile > index 9b7b4d3f..5ae864ab 100644 > --- a/src/packages/fff/fff-wireless/Makefile > +++ b/src/packages/fff/fff-wireless/Makefile > @@ -1,7 +1,7 @@ > include $(TOPDIR)/rules.mk > > PKG_NAME:=fff-wireless > -PKG_RELEASE:=9 > +PKG_RELEASE:=10 > > PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME) > > diff --git a/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless b/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless > index cb057c2d..a51fe7ab 100644 > --- a/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless > +++ b/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless > @@ -43,9 +43,11 @@ esac > > # rssileds > case "$BOARD" in > + cpe210|\ > cpe210-v2|\ > - cpe210-v3) > - uci -q set system.rssid_wlan0.dev=radio0 > - uci -q commit system > + cpe210-v3|\ > + cpe510|\ > + tl-wa850re-v1) > + /etc/init.d/rssileds disable > ;; > esac >
Hmm. Das ist wieder so n Ding, was dann bestimmt für neue Geräte oft vergessen wird.. Da wir die RSSI LEDs aber eh nicht sinnvoll benutzen können, da wir ja AP sind, brauchen wir das eh nicht. Könnte man diesen Dienst nicht einfach für alle Geräte deaktivieren? Reviewed-by: Fabian Bläse <fabian@blaese.de> Gruß Fabian On 19.11.19 15:06, Adrian Schmutzler wrote: > The rssileds set up by OpenWrt cannot be used in our firmware. > Despite that those are bound to "wlan0" initially, we also cannot > change them to one of our interfaces, as the interface recreation > due to configurehood seems to break something in rssileds, causing > high load. > > This patch now disables the rssileds entirely, which has been found > to be the only solution reliably solving the problem of high load > under all circumstances. > > While at it, add all remaining devices with rssileds enabled in > openwrt-18.06. (When updating to openwrt-19.07, most of the ubnt > will have to be added.) > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> > > --- > > This is the result of testing by several people and has been used > successfully for several months. > --- > src/packages/fff/fff-wireless/Makefile | 2 +- > .../files/etc/uci-defaults/62-config-wireless | 8 +++++--- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/packages/fff/fff-wireless/Makefile b/src/packages/fff/fff-wireless/Makefile > index 9b7b4d3f..5ae864ab 100644 > --- a/src/packages/fff/fff-wireless/Makefile > +++ b/src/packages/fff/fff-wireless/Makefile > @@ -1,7 +1,7 @@ > include $(TOPDIR)/rules.mk > > PKG_NAME:=fff-wireless > -PKG_RELEASE:=9 > +PKG_RELEASE:=10 > > PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME) > > diff --git a/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless b/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless > index cb057c2d..a51fe7ab 100644 > --- a/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless > +++ b/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless > @@ -43,9 +43,11 @@ esac > > # rssileds > case "$BOARD" in > + cpe210|\ > cpe210-v2|\ > - cpe210-v3) > - uci -q set system.rssid_wlan0.dev=radio0 > - uci -q commit system > + cpe210-v3|\ > + cpe510|\ > + tl-wa850re-v1) > + /etc/init.d/rssileds disable > ;; > esac >
Hallo Fabian, die Package wird per Device-Packages einzeln hinzugefügt. Man könnte aber natürlich auch prüfen, ob es /etc/init.d/rssileds überhaupt gibt und dann disablen. Oder man könnte die Package beim Bauen gleich entfernen, das wollte ich aber nicht, vll. will sie ja jemand benutzen. Ich habe jetzt aber erstmal die Variante genommen, die ich selbst verwende, damit ich nichts neu testen muss. Grüße Adrian From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf Of Fabian Bläse Sent: Dienstag, 19. November 2019 21:45 To: Adrian Schmutzler <freifunk@adrianschmutzler.de>; franken-dev@freifunk.net Subject: Re: [PATCH 2/2] fff-wireless: improve treatment of dysfunctional rssileds Hmm. Das ist wieder so n Ding, was dann bestimmt für neue Geräte oft vergessen wird.. Da wir die RSSI LEDs aber eh nicht sinnvoll benutzen können, da wir ja AP sind, brauchen wir das eh nicht. Könnte man diesen Dienst nicht einfach für alle Geräte deaktivieren? Reviewed-by: Fabian Bläse <fabian@blaese.de <mailto:fabian@blaese.de> > Gruß Fabian On 19.11.19 15:06, Adrian Schmutzler wrote: > The rssileds set up by OpenWrt cannot be used in our firmware. > Despite that those are bound to "wlan0" initially, we also cannot > change them to one of our interfaces, as the interface recreation > due to configurehood seems to break something in rssileds, causing > high load. > > This patch now disables the rssileds entirely, which has been found > to be the only solution reliably solving the problem of high load > under all circumstances. > > While at it, add all remaining devices with rssileds enabled in > openwrt-18.06. (When updating to openwrt-19.07, most of the ubnt > will have to be added.) > > Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de <mailto:freifunk@adrianschmutzler.de> > > > --- > > This is the result of testing by several people and has been used > successfully for several months. > --- > src/packages/fff/fff-wireless/Makefile | 2 +- > .../files/etc/uci-defaults/62-config-wireless | 8 +++++--- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/packages/fff/fff-wireless/Makefile b/src/packages/fff/fff-wireless/Makefile > index 9b7b4d3f..5ae864ab 100644 > --- a/src/packages/fff/fff-wireless/Makefile > +++ b/src/packages/fff/fff-wireless/Makefile > @@ -1,7 +1,7 @@ > include $(TOPDIR)/rules.mk > > PKG_NAME:=fff-wireless > -PKG_RELEASE:=9 > +PKG_RELEASE:=10 > > PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME) > > diff --git a/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless b/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless > index cb057c2d..a51fe7ab 100644 > --- a/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless > +++ b/src/packages/fff/fff-wireless/files/etc/uci-defaults/62-config-wireless > @@ -43,9 +43,11 @@ esac > > # rssileds > case "$BOARD" in > + cpe210|\ > cpe210-v2|\ > - cpe210-v3) > - uci -q set system.rssid_wlan0.dev=radio0 > - uci -q commit system > + cpe210-v3|\ > + cpe510|\ > + tl-wa850re-v1) > + /etc/init.d/rssileds disable > ;; > esac >
Merged. Beide.
The rssileds set up by OpenWrt cannot be used in our firmware. Despite that those are bound to "wlan0" initially, we also cannot change them to one of our interfaces, as the interface recreation due to configurehood seems to break something in rssileds, causing high load. This patch now disables the rssileds entirely, which has been found to be the only solution reliably solving the problem of high load under all circumstances. While at it, add all remaining devices with rssileds enabled in openwrt-18.06. (When updating to openwrt-19.07, most of the ubnt will have to be added.) Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de> --- This is the result of testing by several people and has been used successfully for several months. --- src/packages/fff/fff-wireless/Makefile | 2 +- .../files/etc/uci-defaults/62-config-wireless | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-)