configuregateway: Print newlines for improved readabilty

Submitted by Fabian Blaese on Aug. 13, 2019, 11 p.m.

Details

Message ID 20190813230044.19667-4-fabian@blaese.de
State Accepted
Headers show

Commit Message

Fabian Blaese Aug. 13, 2019, 11 p.m. 
Signed-off-by: Fabian Bläse <fabian@blaese.de>
---
 src/packages/fff/fff-gateway/files/usr/sbin/configuregateway | 2 ++
 1 file changed, 2 insertions(+)

Patch hide | download patch | download mbox 

diff --git a/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway b/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway
index 3ea67e5..3594a44 100755
--- a/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway
+++ b/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway
@@ -30,6 +30,7 @@  execute_subshell() {
 		)
 
 		if [ $? -ne 0 ]; then
+			echo
 			echo "Error when executing" "$1" "from" "$(basename "$script")"
 			exit 1
 		fi
@@ -43,6 +44,7 @@  configure() {
 		exit 1
 	fi
 
+	echo
 	execute_subshell configure
 
 	exit 0

Comments

Robert Langhammer Aug. 14, 2019, 8:01 a.m. 
hallo Fabian,

Reviewed-by: Robert Langhammer <rlanghammer@web.de>


Das wäre doch mal ein Patch, an dem jemand "neues" den Reviewprozess
ausprobieren könnte. Los - traut euch!! Jetzt!

Grüße Robert

Am 14.08.19 um 01:00 schrieb Fabian Bläse:
> Signed-off-by: Fabian Bläse <fabian@blaese.de>
> ---
>  src/packages/fff/fff-gateway/files/usr/sbin/configuregateway | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway b/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway
> index 3ea67e5..3594a44 100755
> --- a/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway
> +++ b/src/packages/fff/fff-gateway/files/usr/sbin/configuregateway
> @@ -30,6 +30,7 @@ execute_subshell() {
>  		)
>  
>  		if [ $? -ne 0 ]; then
> +			echo
>  			echo "Error when executing" "$1" "from" "$(basename "$script")"
>  			exit 1
>  		fi
> @@ -43,6 +44,7 @@ configure() {
>  		exit 1
>  	fi
>  
> +	echo
>  	execute_subshell configure
>  
>  	exit 0
Fabian Blaese Sept. 8, 2019, 11:26 a.m. 
Hallo zusammen,

On 14.08.19 10:01, robert wrote:
> Das wäre doch mal ein Patch, an dem jemand "neues" den Reviewprozess
> ausprobieren könnte. Los - traut euch!! Jetzt!
^ anyone? :-)

Gruß
Fabian
Fabian Blaese Sept. 29, 2019, 8:17 p.m. 
applied.