[1/6] Use fff-gateway package when compiling layer3 firmware

Submitted by Fabian Blaese on May 25, 2019, 6:48 p.m.

Details

Message ID 20190525184833.20820-2-fabian@blaese.de
State Accepted
Headers show

Commit Message

Fabian Blaese May 25, 2019, 6:48 p.m. 
fff-gateway is mandatory when compiling layer3 firmware.
---
 src/packages/fff/fff/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox 

diff --git a/src/packages/fff/fff/Makefile b/src/packages/fff/fff/Makefile
index 4fec4d3..5b211e6 100644
--- a/src/packages/fff/fff/Makefile
+++ b/src/packages/fff/fff/Makefile
@@ -50,7 +50,8 @@  endef
 define Package/fff-layer3
 	$(call Package/fff/base)
 	TITLE+=(Layer 3 Gateway)
-	DEPENDS+=+fff-dhcp \
+	DEPENDS+=+fff-gateway \
+			 +fff-dhcp \
 			 +fff-babeld \
 			 +fff-ra \
 			 +arptables \

Comments

Adrian Schmutzler May 25, 2019, 6:57 p.m. 
Reviewed-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

Ich wäre aber immer noch sehr dafür, das zu sortieren und nicht einfach irgendwohin zu schreiben.

> -----Original Message-----
> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf
> Of Fabian Bläse
> Sent: Samstag, 25. Mai 2019 20:48
> To: franken-dev@freifunk.net
> Subject: [PATCH 1/6] Use fff-gateway package when compiling layer3
> firmware
> 
> fff-gateway is mandatory when compiling layer3 firmware.
> ---
>  src/packages/fff/fff/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff/Makefile b/src/packages/fff/fff/Makefile
> index 4fec4d3..5b211e6 100644
> --- a/src/packages/fff/fff/Makefile
> +++ b/src/packages/fff/fff/Makefile
> @@ -50,7 +50,8 @@ endef
>  define Package/fff-layer3
>  	$(call Package/fff/base)
>  	TITLE+=(Layer 3 Gateway)
> -	DEPENDS+=+fff-dhcp \
> +	DEPENDS+=+fff-gateway \
> +			 +fff-dhcp \
>  			 +fff-babeld \
>  			 +fff-ra \
>  			 +arptables \
> --
> 2.21.0
Adrian Schmutzler May 25, 2019, 6:59 p.m. 
Hier könnte man auch noch "packages/fff: " vor den Commit-Namen schreiben.

> -----Original Message-----
> From: franken-dev [mailto:franken-dev-bounces@freifunk.net] On Behalf
> Of Fabian Bläse
> Sent: Samstag, 25. Mai 2019 20:48
> To: franken-dev@freifunk.net
> Subject: [PATCH 1/6] Use fff-gateway package when compiling layer3
> firmware
> 
> fff-gateway is mandatory when compiling layer3 firmware.
> ---
>  src/packages/fff/fff/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff/Makefile b/src/packages/fff/fff/Makefile
> index 4fec4d3..5b211e6 100644
> --- a/src/packages/fff/fff/Makefile
> +++ b/src/packages/fff/fff/Makefile
> @@ -50,7 +50,8 @@ endef
>  define Package/fff-layer3
>  	$(call Package/fff/base)
>  	TITLE+=(Layer 3 Gateway)
> -	DEPENDS+=+fff-dhcp \
> +	DEPENDS+=+fff-gateway \
> +			 +fff-dhcp \
>  			 +fff-babeld \
>  			 +fff-ra \
>  			 +arptables \
> --
> 2.21.0
Robert Langhammer May 30, 2019, 11:04 p.m. 
Hi Fabian,

Reviewed-by: Robert Langhammer <rlanghammer@web.de>

Am 25.05.19 um 20:48 schrieb Fabian Bläse:
> fff-gateway is mandatory when compiling layer3 firmware.
> ---
>  src/packages/fff/fff/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/packages/fff/fff/Makefile b/src/packages/fff/fff/Makefile
> index 4fec4d3..5b211e6 100644
> --- a/src/packages/fff/fff/Makefile
> +++ b/src/packages/fff/fff/Makefile
> @@ -50,7 +50,8 @@ endef
>  define Package/fff-layer3
>  	$(call Package/fff/base)
>  	TITLE+=(Layer 3 Gateway)
> -	DEPENDS+=+fff-dhcp \
> +	DEPENDS+=+fff-gateway \
> +			 +fff-dhcp \
>  			 +fff-babeld \
>  			 +fff-ra \
>  			 +arptables \
Fabian Blaese May 31, 2019, 4:31 p.m. 
Fehlendes Signed-off-by ergänzt und mit gewünschter Änderung an der Commitmessage applied.