[v3,11/14] fff-network: Use BATMAN as default for second port

Submitted by Adrian Schmutzler on April 22, 2019, 12:35 p.m.

Details

Message ID 20190422123537.5852-11-freifunk@adrianschmutzler.de
State Deferred
Headers show

Commit Message

Adrian Schmutzler April 22, 2019, 12:35 p.m.
One-ports have CLIENT as default only because they have no initial
WAN. This is not the case for two-port devices. With those,
BATMAN might be the more frequent use case.

Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>

---

New in v3
---
 .../fff/fff-network/files/etc/uci-defaults/22a-config-ports    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports b/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports
index 4cd1387a..88b5b7ac 100644
--- a/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports
+++ b/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports
@@ -18,14 +18,14 @@  case "$BOARD" in
 		;;
 	cpe210|\
 	cpe510)
-		# Default: LAN0: WAN, LAN1: CLIENT
-		setupSwitch "eth0" "0t 4" "0t" "0t 5"
+		# Default: LAN0: WAN, LAN1: BATMAN
+		setupSwitch "eth0" "0t" "0t 4" "0t 5"
 		setupWan "eth0.2"
 		uci set "fff.ui.portsetup=cpev1"
 		;;
 	gl-ar150)
-		# Default: CLIENT
-		setupSwitch "eth1" "0t 1" "0t"
+		# Default: BATMAN
+		setupSwitch "eth1" "0t" "0t 1"
 		setupWan "eth0"
 		uci set "fff.ui.portsetup=2ndport"
 		;;
@@ -73,7 +73,7 @@  case "$BOARD" in
 		;;
 	ubnt-nano-m)
 		setupOnePort "eth0" "WAN"
-		setup2ndEth "eth1" "CLIENT"
+		setup2ndEth "eth1" "BATMAN"
 		uci set "fff.ui.portsetup=twoeth"
 		;;
 	cpe210-v2|\

Comments

Christian Dresel April 22, 2019, 3:38 p.m.
Reviewed-by: Christian Dresel <fff@chrisi01.de>

Gruß

Christian

On 22.04.19 14:35, Adrian Schmutzler wrote:
> One-ports have CLIENT as default only because they have no initial
> WAN. This is not the case for two-port devices. With those,
> BATMAN might be the more frequent use case.
>
> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
>
> ---
>
> New in v3
> ---
>  .../fff/fff-network/files/etc/uci-defaults/22a-config-ports    | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports b/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports
> index 4cd1387a..88b5b7ac 100644
> --- a/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports
> +++ b/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports
> @@ -18,14 +18,14 @@ case "$BOARD" in
>  		;;
>  	cpe210|\
>  	cpe510)
> -		# Default: LAN0: WAN, LAN1: CLIENT
> -		setupSwitch "eth0" "0t 4" "0t" "0t 5"
> +		# Default: LAN0: WAN, LAN1: BATMAN
> +		setupSwitch "eth0" "0t" "0t 4" "0t 5"
>  		setupWan "eth0.2"
>  		uci set "fff.ui.portsetup=cpev1"
>  		;;
>  	gl-ar150)
> -		# Default: CLIENT
> -		setupSwitch "eth1" "0t 1" "0t"
> +		# Default: BATMAN
> +		setupSwitch "eth1" "0t" "0t 1"
>  		setupWan "eth0"
>  		uci set "fff.ui.portsetup=2ndport"
>  		;;
> @@ -73,7 +73,7 @@ case "$BOARD" in
>  		;;
>  	ubnt-nano-m)
>  		setupOnePort "eth0" "WAN"
> -		setup2ndEth "eth1" "CLIENT"
> +		setup2ndEth "eth1" "BATMAN"
>  		uci set "fff.ui.portsetup=twoeth"
>  		;;
>  	cpe210-v2|\
Robert Langhammer April 22, 2019, 9:14 p.m.
Reviewed-by: Robert Langhammer <rlanghammer@web.de>

Am 22.04.19 um 17:38 schrieb Christian Dresel:
> Reviewed-by: Christian Dresel <fff@chrisi01.de>
>
> Gruß
>
> Christian
>
> On 22.04.19 14:35, Adrian Schmutzler wrote:
>> One-ports have CLIENT as default only because they have no initial
>> WAN. This is not the case for two-port devices. With those,
>> BATMAN might be the more frequent use case.
>>
>> Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
>>
>> ---
>>
>> New in v3
>> ---
>>  .../fff/fff-network/files/etc/uci-defaults/22a-config-ports    | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports b/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports
>> index 4cd1387a..88b5b7ac 100644
>> --- a/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports
>> +++ b/src/packages/fff/fff-network/files/etc/uci-defaults/22a-config-ports
>> @@ -18,14 +18,14 @@ case "$BOARD" in
>>  		;;
>>  	cpe210|\
>>  	cpe510)
>> -		# Default: LAN0: WAN, LAN1: CLIENT
>> -		setupSwitch "eth0" "0t 4" "0t" "0t 5"
>> +		# Default: LAN0: WAN, LAN1: BATMAN
>> +		setupSwitch "eth0" "0t" "0t 4" "0t 5"
>>  		setupWan "eth0.2"
>>  		uci set "fff.ui.portsetup=cpev1"
>>  		;;
>>  	gl-ar150)
>> -		# Default: CLIENT
>> -		setupSwitch "eth1" "0t 1" "0t"
>> +		# Default: BATMAN
>> +		setupSwitch "eth1" "0t" "0t 1"
>>  		setupWan "eth0"
>>  		uci set "fff.ui.portsetup=2ndport"
>>  		;;
>> @@ -73,7 +73,7 @@ case "$BOARD" in
>>  		;;
>>  	ubnt-nano-m)
>>  		setupOnePort "eth0" "WAN"
>> -		setup2ndEth "eth1" "CLIENT"
>> +		setup2ndEth "eth1" "BATMAN"
>>  		uci set "fff.ui.portsetup=twoeth"
>>  		;;
>>  	cpe210-v2|\